You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/11 03:28:06 UTC
Review Request 62879: Stopped sending checkpoint resources message on
agent re-registration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62879/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
Given that resource provider capable agents will send update slave
message to the master during re-registration, no need for the master
to send checkpoint resources message to the agent anymore.
This also makes the code more consistent because agent should be the
source of truth. This also eliminates the possible retry incurred by
this message, which is never the intention.
Diffs
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62879/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62879: Stopped sending checkpoint resources
message on agent re-registration.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62879/#review187805
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Oct. 11, 2017, 5:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62879/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Given that resource provider capable agents will send update slave
> message to the master during re-registration, no need for the master
> to send checkpoint resources message to the agent anymore.
>
> This also makes the code more consistent because agent should be the
> source of truth. This also eliminates the possible retry incurred by
> this message, which is never the intention.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
>
>
> Diff: https://reviews.apache.org/r/62879/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62879: Stopped sending checkpoint resources
message on agent re-registration.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62879/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 11:25 p.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
Given that resource provider capable agents will send update slave
message to the master during re-registration, no need for the master
to send checkpoint resources message to the agent anymore.
This also makes the code more consistent because agent should be the
source of truth. This also eliminates the possible retry incurred by
this message, which is never the intention.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62879/diff/3/
Changes: https://reviews.apache.org/r/62879/diff/2-3/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62879: Stopped sending checkpoint resources
message on agent re-registration.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62879/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 7 p.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
Given that resource provider capable agents will send update slave
message to the master during re-registration, no need for the master
to send checkpoint resources message to the agent anymore.
This also makes the code more consistent because agent should be the
source of truth. This also eliminates the possible retry incurred by
this message, which is never the intention.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62879/diff/2/
Changes: https://reviews.apache.org/r/62879/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu