[jira] [Created] (SOLR-14000) clean up more static field leaks in tests

["Robert Muir (Jira)" <ji...@apache.org>]

Robert Muir created SOLR-14000:
----------------------------------

             Summary: clean up more static field leaks in tests
                 Key: SOLR-14000
                 URL: https://issues.apache.org/jira/browse/SOLR-14000
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Robert Muir


See build https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/577/ for example, stuff like this:

{noformat}
Stack Trace:
junit.framework.AssertionFailedError: Clean up static fields (in @AfterClass?) and null them, your test still has references to classes of which the sizes cannot be measured due to security restrictions or Java 9 module encapsulation:
  - private static org.apache.solr.prometheus.scraper.SolrStandaloneScraper org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrScraper
  - private static org.apache.solr.client.solrj.impl.HttpSolrClient org.apache.solr.prometheus.scraper.SolrStandaloneScraperTest.solrClient
{noformat}

Looks like security manager issue, but its not, its just static leaks in tests. Its just that the thing they leak can't be inspected to see how "big" the leak is (apparently the objects were below some threshold before).

We should just plug the leaks, null them out in AfterClass.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org