You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2022/04/07 13:25:02 UTC

Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73935/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3669
    https://issues.apache.org/jira/browse/RANGER-3669


Repository: ranger


Description
-------

Ranger KMS db setup script needs to be updated to support MySql versions greater than 8.0
Made changes to allow non-ssl connection with DB for Mysql version greater than 8.0
made a fix to allow user to define the custom jdbc url which can be used in db-setup.
Added missing change for Ranger Admin db-setup in RANGER-3647


Diffs
-----

  kms/scripts/db_setup.py 165e30d89443b7e8244ed965c34a5d7219e7d1f3 
  kms/scripts/install.properties 780509dcdd06c13e84f1a860213eb28f3556fa26 
  security-admin/scripts/db_setup.py eaae5c8990724d7ead703d747140a0c3c49289d7 


Diff: https://reviews.apache.org/r/73935/diff/1/


Testing
-------

Validated changes locally with available Mysql-8.0 release.


Thanks,

Vishal Suvagia


Re: Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73935/#review224319
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On April 8, 2022, 10:57 a.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73935/
> -----------------------------------------------------------
> 
> (Updated April 8, 2022, 10:57 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3669
>     https://issues.apache.org/jira/browse/RANGER-3669
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger KMS db setup script needs to be updated to support MySql versions greater than 8.0
> Made changes to allow non-ssl connection with DB for Mysql version greater than 8.0
> made a fix to allow user to define the custom jdbc url which can be used in db-setup.
> Added missing change for Ranger Admin db-setup in RANGER-3647
> 
> 
> Diffs
> -----
> 
>   kms/scripts/db_setup.py 165e30d89443b7e8244ed965c34a5d7219e7d1f3 
>   kms/scripts/install.properties 780509dcdd06c13e84f1a860213eb28f3556fa26 
>   security-admin/scripts/db_setup.py eaae5c8990724d7ead703d747140a0c3c49289d7 
> 
> 
> Diff: https://reviews.apache.org/r/73935/diff/1/
> 
> 
> Testing
> -------
> 
> Validated changes locally with available Mysql-8.0 release.
> 
> 
> File Attachments
> ----------------
> 
> RANGER-3669.01.patch
>   https://reviews.apache.org/media/uploaded/files/2022/04/08/48106a24-5c65-47d3-b971-7b69f5d7bb79__RANGER-3669.01.patch
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73935/#review224292
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On April 8, 2022, 10:57 a.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73935/
> -----------------------------------------------------------
> 
> (Updated April 8, 2022, 10:57 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3669
>     https://issues.apache.org/jira/browse/RANGER-3669
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger KMS db setup script needs to be updated to support MySql versions greater than 8.0
> Made changes to allow non-ssl connection with DB for Mysql version greater than 8.0
> made a fix to allow user to define the custom jdbc url which can be used in db-setup.
> Added missing change for Ranger Admin db-setup in RANGER-3647
> 
> 
> Diffs
> -----
> 
>   kms/scripts/db_setup.py 165e30d89443b7e8244ed965c34a5d7219e7d1f3 
>   kms/scripts/install.properties 780509dcdd06c13e84f1a860213eb28f3556fa26 
>   security-admin/scripts/db_setup.py eaae5c8990724d7ead703d747140a0c3c49289d7 
> 
> 
> Diff: https://reviews.apache.org/r/73935/diff/1/
> 
> 
> Testing
> -------
> 
> Validated changes locally with available Mysql-8.0 release.
> 
> 
> File Attachments
> ----------------
> 
> RANGER-3669.01.patch
>   https://reviews.apache.org/media/uploaded/files/2022/04/08/48106a24-5c65-47d3-b971-7b69f5d7bb79__RANGER-3669.01.patch
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>


Re: Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73935/
-----------------------------------------------------------

(Updated April 8, 2022, 10:57 a.m.)


Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Apologies had uploaded a previous version of patch by mistake, updated with proper fix.


Bugs: RANGER-3669
    https://issues.apache.org/jira/browse/RANGER-3669


Repository: ranger


Description
-------

Ranger KMS db setup script needs to be updated to support MySql versions greater than 8.0
Made changes to allow non-ssl connection with DB for Mysql version greater than 8.0
made a fix to allow user to define the custom jdbc url which can be used in db-setup.
Added missing change for Ranger Admin db-setup in RANGER-3647


Diffs
-----

  kms/scripts/db_setup.py 165e30d89443b7e8244ed965c34a5d7219e7d1f3 
  kms/scripts/install.properties 780509dcdd06c13e84f1a860213eb28f3556fa26 
  security-admin/scripts/db_setup.py eaae5c8990724d7ead703d747140a0c3c49289d7 


Diff: https://reviews.apache.org/r/73935/diff/1/


Testing
-------

Validated changes locally with available Mysql-8.0 release.


File Attachments (updated)
----------------

RANGER-3669.01.patch
  https://reviews.apache.org/media/uploaded/files/2022/04/08/48106a24-5c65-47d3-b971-7b69f5d7bb79__RANGER-3669.01.patch


Thanks,

Vishal Suvagia