You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Tom Jordahl <to...@macromedia.com> on 2004/04/08 15:15:36 UTC
Tabs
How the heck did we get so many tabs in our source?
Patches?
--
Tom Jordahl
Macromedia Server Development
Re: Minor change to SymbolTable.java
Posted by Davanum Srinivas <di...@yahoo.com>.
+1. Got for it.
--- Jarek Gawor <ga...@mcs.anl.gov> wrote:
> Does anyone object if the following change is made to SymbolTable.java?:
>
> Index: org/apache/axis/wsdl/symbolTable/SymbolTable.java
> ===================================================================
> RCS file:
> /home/cvspublic/ws-axis/java/src/org/apache/axis/wsdl/symbolTable/Symb
> olTable.java,v
> retrieving revision 1.95
> diff -u -r1.95 SymbolTable.java
> --- org/apache/axis/wsdl/symbolTable/SymbolTable.java 8 Apr 2004 13:09:07
> -000
> 0 1.95
> +++ org/apache/axis/wsdl/symbolTable/SymbolTable.java 9 Apr 2004 07:44:30
> -000
> 0
> @@ -1702,7 +1702,10 @@
> } else if (outdex >= 0) {
> addOutParm(outputs, outdex, parameters, true);
> } else {
> - System.err.println(Messages.getMessage("noPart00",
> name));
> + if (verbose) {
> + System.err.println(Messages.getMessage("noPart00",
> + name));
> + }
> }
> }
> }
> @@ -3545,8 +3548,10 @@
> }
> }
> } else {
> - System.out.println(Messages.getMessage("alreadyExists00",
> - "" + name));
> + if (verbose) {
> + System.out.println(Messages.getMessage("alreadyExists00",
> + "" + name));
> + }
> }
> } // symbolTablePut
>
=====
Davanum Srinivas - http://webservices.apache.org/~dims/
Minor change to SymbolTable.java
Posted by Jarek Gawor <ga...@mcs.anl.gov>.
Does anyone object if the following change is made to SymbolTable.java?:
Index: org/apache/axis/wsdl/symbolTable/SymbolTable.java
===================================================================
RCS file:
/home/cvspublic/ws-axis/java/src/org/apache/axis/wsdl/symbolTable/Symb
olTable.java,v
retrieving revision 1.95
diff -u -r1.95 SymbolTable.java
--- org/apache/axis/wsdl/symbolTable/SymbolTable.java 8 Apr 2004 13:09:07
-000
0 1.95
+++ org/apache/axis/wsdl/symbolTable/SymbolTable.java 9 Apr 2004 07:44:30
-000
0
@@ -1702,7 +1702,10 @@
} else if (outdex >= 0) {
addOutParm(outputs, outdex, parameters, true);
} else {
- System.err.println(Messages.getMessage("noPart00",
name));
+ if (verbose) {
+ System.err.println(Messages.getMessage("noPart00",
+ name));
+ }
}
}
}
@@ -3545,8 +3548,10 @@
}
}
} else {
- System.out.println(Messages.getMessage("alreadyExists00",
- "" + name));
+ if (verbose) {
+ System.out.println(Messages.getMessage("alreadyExists00",
+ "" + name));
+ }
}
} // symbolTablePut
Re: Tabs
Posted by Richard Martin <rm...@essex.ac.uk>.
Maybe the key is to enforce a standard process for reviewing, validating
and integrating patches (if such does not allready exist).
Perhaps all patches should be forwarded to one developer who integrates
the patches into a sandbox installation? For anyone who hasn't used
them, I can reccomend JCSC (http://sourceforge.net/projects/jcsc/) or
Checkstyle (http://checkstyle.sourceforge.net/). Running one of against
the new code base, then running all functional tests in Ant should
address the problem of poor coding standards, naming conventions etc
etc. This should help with the legibility of the code, making it easier
to read and understand.
I'm not sure what can be done with regards to architectural consistency.
A review by a developer who is fimiliar with the architecture, and the
direction that
it needs to go in the future? The result of that is a tradeoff however;
enforcing the integrity may mean refactoring some of the patches
submitted and this both generates more work for the devloper and makes
the original patch pointless.
Regards,
Richard
Glen Daniels wrote:
>Hm. Maybe we should be a little more careful about committing these things.
>Actually, I've been thinking about that for a while now, not just in terms
>of lexical/style stuff, but in terms of architectural consistency. Our
>source has a bunch of "band aid" fixes at this point which add up in terms
>of making the system as a whole harder to comprehend and maintain....
>
>I'm not sure what the right solution to this is, 'cause we certainly want to
>encourage patches!
>
>--Glen
>
>----- Original Message -----
>From: "Davanum Srinivas" <di...@yahoo.com>
>To: <ax...@ws.apache.org>
>Sent: Thursday, April 08, 2004 9:16 AM
>Subject: Re: Tabs
>
>
>
>
>>i think so :)
>>
>>--- Tom Jordahl <to...@macromedia.com> wrote:
>>
>>
>>>How the heck did we get so many tabs in our source?
>>>
>>>Patches?
>>>
>>>--
>>>Tom Jordahl
>>>Macromedia Server Development
>>>
>>>
>>>
>>>
>>=====
>>Davanum Srinivas - http://webservices.apache.org/~dims/
>>
>>
>>
>>
>
>
>
Re: Tabs
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hm. Maybe we should be a little more careful about committing these things.
Actually, I've been thinking about that for a while now, not just in terms
of lexical/style stuff, but in terms of architectural consistency. Our
source has a bunch of "band aid" fixes at this point which add up in terms
of making the system as a whole harder to comprehend and maintain....
I'm not sure what the right solution to this is, 'cause we certainly want to
encourage patches!
--Glen
----- Original Message -----
From: "Davanum Srinivas" <di...@yahoo.com>
To: <ax...@ws.apache.org>
Sent: Thursday, April 08, 2004 9:16 AM
Subject: Re: Tabs
> i think so :)
>
> --- Tom Jordahl <to...@macromedia.com> wrote:
> > How the heck did we get so many tabs in our source?
> >
> > Patches?
> >
> > --
> > Tom Jordahl
> > Macromedia Server Development
> >
> >
>
>
> =====
> Davanum Srinivas - http://webservices.apache.org/~dims/
>
>
Re: Tabs
Posted by Davanum Srinivas <di...@yahoo.com>.
i think so :)
--- Tom Jordahl <to...@macromedia.com> wrote:
> How the heck did we get so many tabs in our source?
>
> Patches?
>
> --
> Tom Jordahl
> Macromedia Server Development
>
>
=====
Davanum Srinivas - http://webservices.apache.org/~dims/