You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2012/01/29 14:59:56 UTC
[VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Hi all again mates :)
after the failing RC1, I open the VOTE for Apache Commons validator
1.4.0 based on RC2. Follow details:
Tag:
https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
Release notes:
http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
Site:
http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
(broken links in the sidebar will be fixed once the site will be
redeployed)
Binaries:
http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
Maven Artifacts
https://repository.apache.org/content/repositories/orgapachecommons-153
[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -0 not blocking, but...
[ ] -1 no, do not release it because...
Many thanks in advance for reviewing, all the best and have a nice day!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 01/02/2012 13:44, Nick Burch a écrit :
> On Wed, 1 Feb 2012, Simone Tripodi wrote:
>> thanks for reviewing! I am personally worried to fix the findbugs
>> errors and break the backward compatibility, I'll ask Nick's help!
>
> I'm not sure how serious those warnings are, and I'm pretty sure that
> those problems were present in 1.3, so I think that means they're
> probably not a blocker!
OK, then +1 from me.
Luc
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Nick Burch <ni...@alfresco.com>.
On Wed, 1 Feb 2012, Simone Tripodi wrote:
> thanks for reviewing! I am personally worried to fix the findbugs errors
> and break the backward compatibility, I'll ask Nick's help!
I'm not sure how serious those warnings are, and I'm pretty sure that
those problems were present in 1.3, so I think that means they're probably
not a blocker!
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Simone Tripodi <si...@apache.org>.
Salut Luc,
thanks for reviewing! I am personally worried to fix the findbugs
errors and break the backward compatibility, I'll ask Nick's help!
Anyway, no issues from my side to cut out an improved RC!!
A trés bientôt!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Wed, Feb 1, 2012 at 10:21 AM, Luc Maisonobe <Lu...@free.fr> wrote:
> Le 30/01/2012 19:18, Gary Gregory a écrit :
>> -0:
>>
>> The text in RELEASE-NOTES.txt contradicts itself:
>>
>> First we say:
>> "
>> IMPORTANT NOTES
>> ================
>>
>> BREAKING CHANGES:
>>
>> * NONE.
>> "
>>
>> Then at the end we say:
>>
>> "
>> OTHER NOTES
>> ============
>>
>> Users should be aware of the following potential issues with migration:
>>
>> * The protected method validator.EmailValidator.isValidIpAddress()
>> previously
>> exposed a Jakarta ORO class via its signature. The signature has been
>> modified to accept a a java.lang.String and is not therefore not
>> compatible.
>> However, this class is deprecated and clients should use the equivalent
>> class in the validator.routines package.
>>
>> * Invocations of the method GenericValidator.matchRegexp() should be
>> inspected
>> for semantic differences between Jakarta ORO and Java regular expressions.
>> "
>>
>> The release is therefore binary incompatible (a "BREAKING" change) for the
>> first reason and semantically incompatible for the second (a different kind
>> of "BREAKING" change). This should be filed under "IMPORTANT" IMO, not an
>> "OTHER" note.
>>
>> Not blockers, but should be fixed (easy):
>>
>> Checkstyle: 4 x "Expected @param tag for ..."
>
> I agree, these one are non-blockers.
>
>>
>> Then these are unknown as to blockers: 2 findbugs issues:
>>
>> Inconsistent synchronization of
>> org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time
>> MT_CORRECTNESSIS2_INCONSISTENT_SYNC<http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC>
>> 348MediumClass org.apache.commons.validator.ValidatorAction defines
>> non-transient non-serializable instance field validationMethodBAD_PRACTICE
>> SE_BAD_FIELD<http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD>Not
>> availableHigh
>
> I'm not sure either about these issues. Simone, could you check if they
> are worht another RC or not ?
> I'll cast my vote according to your answer about these issues.
>
> thanks
> Luc
>
>> Gary
>>
>> On Sun, Jan 29, 2012 at 8:59 AM, Simone Tripodi <si...@apache.org>wrote:
>>
>>> Hi all again mates :)
>>>
>>> after the failing RC1, I open the VOTE for Apache Commons validator
>>> 1.4.0 based on RC2. Follow details:
>>>
>>> Tag:
>>>
>>>
>>> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>>>
>>> Release notes:
>>>
>>>
>>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
>>>
>>> Site:
>>>
>>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
>>> (broken links in the sidebar will be fixed once the site will be
>>> redeployed)
>>>
>>> Binaries:
>>>
>>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>>>
>>> Maven Artifacts
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-153
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -0 not blocking, but...
>>> [ ] -1 no, do not release it because...
>>>
>>> Many thanks in advance for reviewing, all the best and have a nice day!
>>> -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Luc Maisonobe <Lu...@free.fr>.
Le 30/01/2012 19:18, Gary Gregory a écrit :
> -0:
>
> The text in RELEASE-NOTES.txt contradicts itself:
>
> First we say:
> "
> IMPORTANT NOTES
> ================
>
> BREAKING CHANGES:
>
> * NONE.
> "
>
> Then at the end we say:
>
> "
> OTHER NOTES
> ============
>
> Users should be aware of the following potential issues with migration:
>
> * The protected method validator.EmailValidator.isValidIpAddress()
> previously
> exposed a Jakarta ORO class via its signature. The signature has been
> modified to accept a a java.lang.String and is not therefore not
> compatible.
> However, this class is deprecated and clients should use the equivalent
> class in the validator.routines package.
>
> * Invocations of the method GenericValidator.matchRegexp() should be
> inspected
> for semantic differences between Jakarta ORO and Java regular expressions.
> "
>
> The release is therefore binary incompatible (a "BREAKING" change) for the
> first reason and semantically incompatible for the second (a different kind
> of "BREAKING" change). This should be filed under "IMPORTANT" IMO, not an
> "OTHER" note.
>
> Not blockers, but should be fixed (easy):
>
> Checkstyle: 4 x "Expected @param tag for ..."
I agree, these one are non-blockers.
>
> Then these are unknown as to blockers: 2 findbugs issues:
>
> Inconsistent synchronization of
> org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time
> MT_CORRECTNESSIS2_INCONSISTENT_SYNC<http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC>
> 348MediumClass org.apache.commons.validator.ValidatorAction defines
> non-transient non-serializable instance field validationMethodBAD_PRACTICE
> SE_BAD_FIELD<http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD>Not
> availableHigh
I'm not sure either about these issues. Simone, could you check if they
are worht another RC or not ?
I'll cast my vote according to your answer about these issues.
thanks
Luc
> Gary
>
> On Sun, Jan 29, 2012 at 8:59 AM, Simone Tripodi <si...@apache.org>wrote:
>
>> Hi all again mates :)
>>
>> after the failing RC1, I open the VOTE for Apache Commons validator
>> 1.4.0 based on RC2. Follow details:
>>
>> Tag:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>>
>> Release notes:
>>
>>
>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
>>
>> Site:
>>
>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
>> (broken links in the sidebar will be fixed once the site will be
>> redeployed)
>>
>> Binaries:
>>
>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>>
>> Maven Artifacts
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-153
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -0 not blocking, but...
>> [ ] -1 no, do not release it because...
>>
>> Many thanks in advance for reviewing, all the best and have a nice day!
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Gary Gregory <ga...@gmail.com>.
-0:
The text in RELEASE-NOTES.txt contradicts itself:
First we say:
"
IMPORTANT NOTES
================
BREAKING CHANGES:
* NONE.
"
Then at the end we say:
"
OTHER NOTES
============
Users should be aware of the following potential issues with migration:
* The protected method validator.EmailValidator.isValidIpAddress()
previously
exposed a Jakarta ORO class via its signature. The signature has been
modified to accept a a java.lang.String and is not therefore not
compatible.
However, this class is deprecated and clients should use the equivalent
class in the validator.routines package.
* Invocations of the method GenericValidator.matchRegexp() should be
inspected
for semantic differences between Jakarta ORO and Java regular expressions.
"
The release is therefore binary incompatible (a "BREAKING" change) for the
first reason and semantically incompatible for the second (a different kind
of "BREAKING" change). This should be filed under "IMPORTANT" IMO, not an
"OTHER" note.
Not blockers, but should be fixed (easy):
Checkstyle: 4 x "Expected @param tag for ..."
Then these are unknown as to blockers: 2 findbugs issues:
Inconsistent synchronization of
org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time
MT_CORRECTNESSIS2_INCONSISTENT_SYNC<http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC>
348MediumClass org.apache.commons.validator.ValidatorAction defines
non-transient non-serializable instance field validationMethodBAD_PRACTICE
SE_BAD_FIELD<http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD>Not
availableHigh
Gary
On Sun, Jan 29, 2012 at 8:59 AM, Simone Tripodi <si...@apache.org>wrote:
> Hi all again mates :)
>
> after the failing RC1, I open the VOTE for Apache Commons validator
> 1.4.0 based on RC2. Follow details:
>
> Tag:
>
>
> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>
> Release notes:
>
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
>
> Site:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
> (broken links in the sidebar will be fixed once the site will be
> redeployed)
>
> Binaries:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>
> Maven Artifacts
>
> https://repository.apache.org/content/repositories/orgapachecommons-153
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -0 not blocking, but...
> [ ] -1 no, do not release it because...
>
> Many thanks in advance for reviewing, all the best and have a nice day!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Simone Tripodi <si...@apache.org>.
that is my +1.
@Nick: I've been using my GPG key for many releases, so I agree that
should not be blocking - otherwise we should invalidate older releases
:P
Thanks anyway for the hint! Next ApacheCon should be in Germany IUUC -
that would be the right chance for me to get the required signature!
All the best, have a nice day!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Jan 30, 2012 at 1:35 PM, Nick Burch <ni...@alfresco.com> wrote:
> On Sun, 29 Jan 2012, Simone Tripodi wrote:
>>
>> after the failing RC1, I open the VOTE for Apache Commons validator 1.4.0
>> based on RC2. Follow details:
>
>
> Looks fine to me, I'm +1
>
> My only comment is that it doesn't look like your GPG key has been signed by
> anyone. I don't think that's a blocker, but it'd be good to get your into
> the Web Of Trust. Next time you're at[1] an Apache Event, don't forget to
> get some people to sign it!
>
> Nick
>
> [1] At an existing one, or maybe even at one you organise yourself?
> ConCom <http://www.apache.org/foundation/conferences.html> can provide
> advice, mentorship etc if you want to do an Apache Event! :)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Nick Burch <ni...@alfresco.com>.
On Sun, 29 Jan 2012, Simone Tripodi wrote:
> after the failing RC1, I open the VOTE for Apache Commons validator
> 1.4.0 based on RC2. Follow details:
Looks fine to me, I'm +1
My only comment is that it doesn't look like your GPG key has been signed
by anyone. I don't think that's a blocker, but it'd be good to get your
into the Web Of Trust. Next time you're at[1] an Apache Event, don't
forget to get some people to sign it!
Nick
[1] At an existing one, or maybe even at one you organise yourself?
ConCom <http://www.apache.org/foundation/conferences.html> can provide
advice, mentorship etc if you want to do an Apache Event! :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Nick Burch <ni...@alfresco.com>.
On Sun, 29 Jan 2012, Oliver Heger wrote:
> Looks good now, my concerns have been addressed. The only minor nit I found
> is that the ant build is not able to execute the tests. It fails with
> test.main:
> [echo] Running main tests ...
> [java] Class not found "org.apache.commons.validator.ValidatorTestSuite"
>
> But this is not blocking.
Should be fixed in r1237417, I too think it's probably not a blocker
though
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Oliver Heger <ol...@oliver-heger.de>.
+1
Looks good now, my concerns have been addressed. The only minor nit I
found is that the ant build is not able to execute the tests. It fails with
test.main:
[echo] Running main tests ...
[java] Class not found
"org.apache.commons.validator.ValidatorTestSuite"
But this is not blocking.
Oliver
Am 29.01.2012 14:59, schrieb Simone Tripodi:
> Hi all again mates :)
>
> after the failing RC1, I open the VOTE for Apache Commons validator
> 1.4.0 based on RC2. Follow details:
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>
> Release notes:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
>
> Site:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
> (broken links in the sidebar will be fixed once the site will be
> redeployed)
>
> Binaries:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>
> Maven Artifacts
>
> https://repository.apache.org/content/repositories/orgapachecommons-153
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -0 not blocking, but...
> [ ] -1 no, do not release it because...
>
> Many thanks in advance for reviewing, all the best and have a nice day!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Posted by Jörg Schaible <jo...@gmx.de>.
Simone Tripodi wrote:
> Hi all again mates :)
>
> after the failing RC1, I open the VOTE for Apache Commons validator
> 1.4.0 based on RC2. Follow details:
>
> Tag:
>
>
https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>
> Release notes:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-
NOTES.txt
>
> Site:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
> (broken links in the sidebar will be fixed once the site will be
> redeployed)
>
> Binaries:
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>
> Maven Artifacts
>
> https://repository.apache.org/content/repositories/orgapachecommons-153
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -0 not blocking, but...
> [ ] -1 no, do not release it because...
+1, looks good, could build from source with my compiler zoo.
- Jörg
BTW: The serialization problem can be fixed even if binary compatibility is
violated. Since no instance of ValidatorAction could be serialized, binary
compatibility is moot ;-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org