You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lriggs (via GitHub)" <gi...@apache.org> on 2025/02/12 01:01:45 UTC
[PR] GH-601 Synchronize some methods on the Projector. [arrow-java]
lriggs opened a new pull request, #602:
URL: https://github.com/apache/arrow-java/pull/602
### Rationale for this change
Multiple threads can attempt to create the same llvm expression in Gandiva. This isn't allowed with the new JIT compiler, so synchronizing will prevent this scenario.
### What changes are included in this PR?
Synchronize some methods to avoid adding duplicate llvm expressions.
### Are these changes tested?
Yes, through unit tests in Gandiva.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2672317928
I rebased but don't seem to have permissions to add the bug-fix label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #602:
URL: https://github.com/apache/arrow-java/pull/602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2655065974
> @lriggs since you've been working on Gandiva lately, would you be able to help take a look at the changes here?
Ok I'm clearly not paying attention...you are lriggs :grimacing:
As Kou states, let's rebase this after the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2652756827
We should rebase on main after we merge GH-595.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601 Synchronize some methods on the Projector [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2652695110
@lriggs since you've been working on Gandiva lately, would you be able to help take a look at the changes here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2672285648
<!-- label_helper_comment -->
Thank you for opening a pull request!
Please label the PR with one or more of:
- bug-fix
- chore
- dependencies
- documentation
- enhancement
Also, add the 'breaking-change' label if appropriate.
See [CONTRIBUTING.md](https://github.com/apache/arrow-java/blob/main/CONTRIBUTING.md) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-601: [Gandiva] Synchronize some methods on the Projector [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #602:
URL: https://github.com/apache/arrow-java/pull/602#issuecomment-2670887258
Could you rebase on main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org