You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/01 19:13:11 UTC
[kudu-CR] Bump gflags to 2.2.0
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6207
to review the following change.
Change subject: Bump gflags to 2.2.0
......................................................................
Bump gflags to 2.2.0
Flags can now be specified with dashes instead of underscores\u203c\ufe0f\ufe0f
Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6207/1
--
To view, visit http://gerrit.cloudera.org:8080/6207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Bump gflags to 2.2.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Bump gflags to 2.2.0
......................................................................
Bump gflags to 2.2.0
Flags can now be specified with dashes instead of underscores\u203c\ufe0f\ufe0f
Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
Reviewed-on: http://gerrit.cloudera.org:8080/6207
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Bump gflags to 2.2.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Bump gflags to 2.2.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6207/1//COMMIT_MSG
Commit Message:
Line 9: Flags can now be specified with dashes instead of underscores\u203c\ufe0f\ufe0f
hooray! my greatest contribution to society ever
--
To view, visit http://gerrit.cloudera.org:8080/6207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Bump gflags to 2.2.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Bump gflags to 2.2.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I400dc8eb74cce47848497342dbe5f945e1a98461
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No