You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 07:16:12 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #15609: Remove the `not-allow-trailing-slash` rule on S3_hook

eladkal commented on a change in pull request #15609:
URL: https://github.com/apache/airflow/pull/15609#discussion_r634107986



##########
File path: UPDATING.md
##########
@@ -100,6 +100,10 @@ serve as a DagBag cache burst time.
 
 The `default_queue` configuration option has been moved from `[celery]` section to `[operators]` section to allow for re-use between different executors.
 
+### Update `parse_s3_url` in airflow.providers.amazon.aws.hooks.s3.S3Hook
+
+The `parse_s3_url` method in `airflow.providers.amazon.aws.hooks.s3.S3Hook` will now not remove the trailing slash by default. This will allow user to more flexibly implement their preferred prefix-level or subdirectory-level s3 operations.
+

Review comment:
       The change of this PR effects only Amazon provider so the note should be in the provider change log https://github.com/apache/airflow/blob/master/airflow/providers/amazon/CHANGELOG.rst
   
   If this change is not backward compatible probably we need to bump major version in the [provider yaml](https://github.com/apache/airflow/blob/master/airflow/providers/amazon/provider.yaml#L24) @potiuk this means 2.0.0 correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org