[PATCH] warning fix

[Ben Collins-Sussman <su...@collab.net>]

I just built httpd-2.0 out of CVS a minute ago, and I'm getting a
warning on my FreeBSD 4.5 system (gcc 2.95.3):

 httpd-2.0/server/log.c:221: warning: control reaches end of non-void function

I'm just a passing APR/Subversion developer, but hey, I thought maybe
this is the correct patch for log.c:1.116:


Index: log.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/log.c,v
retrieving revision 1.116
diff -u -r1.116 log.c
--- log.c	17 Apr 2002 16:36:28 -0000	1.116
+++ log.c	17 Apr 2002 19:52:45 -0000
@@ -218,6 +218,8 @@
                      "unable to replace stderr with error_log");
         return rc;
     }
+    
+    return rc;
 }
 
 static int log_child(apr_pool_t *p, const char *progname,

Re: [PATCH] warning fix

[Justin Erenkrantz <je...@apache.org>]

On Wed, Apr 17, 2002 at 03:07:37PM -0500, Ben Collins-Sussman wrote:
> 
> I just built httpd-2.0 out of CVS a minute ago, and I'm getting a
> warning on my FreeBSD 4.5 system (gcc 2.95.3):
> 
>  httpd-2.0/server/log.c:221: warning: control reaches end of non-void function
> 
> I'm just a passing APR/Subversion developer, but hey, I thought maybe
> this is the correct patch for log.c:1.116:

A variant of this was committed.  Thanks!  -- justin