[GitHub] thrift pull request #1414: Combined THRIFT-4329 with multiprotocol addition ...

[jeking3 <gi...@git.apache.org>]

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1414

    Combined THRIFT-4329 with multiprotocol addition to cpp for THRIFT-2013 and other cleanup

    This supercedes #1361 (because it contains the changes in that PR, plus others for THRIFT-2013).
    
    * Adds cross server multiplexed to c_glib, per THRIFT-4329
    * Adds cross server and client multiplexed testing to cpp for THRIFT-2013 (with default processor option)
    * Adds cross client multiplexed testing to java for THRIFT-2013 (it had server side already)
    * Adds cross client multiplexed testing to java for THRIFT-2013
    * Fixes a serious bug in the cpp THeaderProtocolFactory
    * Fixes a bug in the cpp TSSLSocket handling disconnect from SSL_read
    * Removes a sleep in the cpp testOneway implementation that was unnecessary (makes cross tests cpp-cpp quite fast)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift add-multi-cpp-cross

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1414
    
----
commit cc320fd4f06006269c921adca240589159434799
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date:   2017-09-15T10:26:02Z

    Implement multiplexed processor that matches CPP and Java. Tested against Java
    Missing Test suite
    Implement stored message protocol that adds the posibility of reading a header of a message and then process it
    Fix problem freeing hashtable since no copy of key was made. Making the free of the key to fail
    Fix memory leak by freeing the intermediate protocol after its use.
    Remove comment on decorator.
    Don't unitialize the stored message protocol used to mask in protocol. Since it makes everything fail. Memory lose will ocur
    Add protocol decorator to the CmakeLists
    Fixed a possible bug on multiplexed processor were multiplexed processor was not ref, but unref.
    Remove some debug statetment
    Implement multiplexed processor server on integration testing.
    It seems the tests has to be added to tests.
    Added multiple multiplexed protocols to c_glib.
    Corrected a bug in the test client where the result was not checked correctly.
    Add a possible bugfix in error handler in upper processor.
    Add a fix on the test server to find the compact protocol even when multic is used
    Fix a bug while opening. It didn't control if SSL socket was really opened.
    Fix a bug while opening. It didn't closed the underlaying socket when SSL error happens on connect.
    Fix a bug on all transport transfer functions. It tried blindly to perform the action. Even if the socket was not properly configured/opened.
    Fix error handling. Now we return a correct error.
    Various optimizations.
    Check error messages on tests
    Fix open and close tests
    Remove string_limit and container_limit tests from binary protocol since it doesn't support it
    Fix bug in transport socket. I removed buf definition by error.
    Move close upper so we don't have implicit declaration warning
    Add error variable
    Adapt the code to C90 as required by jeking3

commit 9b3f11afec1898f121933e93d095569b6c626a5e
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date:   2017-11-13T08:32:27Z

    Remove error caused by -Werror=format-security

commit eae78461c3f53995f8761417dbb8f189f81e48d8
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date:   2017-11-13T19:17:19Z

    Fix discrepancy in tests

commit f9e90050b18112d586724807fd9faf289bd6f8c0
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date:   2017-11-13T19:36:51Z

    Avoid strings larger than testString("thing") to pass

commit 8ca1c1320006008aa006a91714e449fbc5fecb3d
Author: James E. King, III <jk...@apache.org>
Date:   2017-11-17T19:41:46Z

    THRIFT-2013: add multiplex server and client test support to cpp language
    add multiplex client test support to csharp and java languages
    fix a bug in the server-side header protocol factory
    fix a bug in the cpp SSL server socket implementation
    remove unnecessary sleep in cpp server testOneway

----


---

[GitHub] thrift pull request #1414: Combined THRIFT-4329 with multiprotocol addition ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1414


---