You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/10 22:08:45 UTC
[GitHub] [yunikorn-k8shim] kannon92 opened a new pull request, #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
kannon92 opened a new pull request, #478:
URL: https://github.com/apache/yunikorn-k8shim/pull/478
### What is this PR for?
In my researching Yunikorn, I wanted to see if its possible to use MPIJob from Kubeflow with Yunikorn.
I added an example from the Kubeflow examples and adding some yunikorn annotations.
This PR adds an example to the deployment/examples repo to show how you could use yunikorn and MPIJob.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [x] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
1) Clone Kubeflow mpijob repo.
2) Deploy v2beta controller
3) Run the pi.yaml job
4) Use the UI to view that yunikorn correctly reports the MPIJob
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on PR #478:
URL: https://github.com/apache/yunikorn-k8shim/pull/478#issuecomment-1312775333
I forgot to describe the environment.
I adopts rancher desktop to simulate the k8s cluster.
My environment is:
The master node contains 2 cpu and 2G memory.
Kubernetes version is v1.23.10
Yunikorn version is v1.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
URL: https://github.com/apache/yunikorn-k8shim/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #478:
URL: https://github.com/apache/yunikorn-k8shim/pull/478#issuecomment-1312775086
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/478?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#478](https://codecov.io/gh/apache/yunikorn-k8shim/pull/478?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f91960) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/98ef41f05bf39b2a718ab1ed5c97e5377919f66e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ef41f) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #478 +/- ##
=======================================
Coverage 68.37% 68.37%
=======================================
Files 42 42
Lines 6998 6998
=======================================
Hits 4785 4785
Misses 2042 2042
Partials 171 171
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #478: YUNIKORN-1390 - MPI Operator Example in k8-shim repo
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #478:
URL: https://github.com/apache/yunikorn-k8shim/pull/478#issuecomment-1311065505
Hi @kannon92 can you check the pre-commit run please? I think it is purely due to the fact that the files must have a proper header which is missing.
Beside that I do not think anything is stopping us from adding this to the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org