You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by snuf <gi...@git.apache.org> on 2015/03/27 11:29:35 UTC
[GitHub] cloudstack pull request: Ovm3firefix: fixes for unit tests on Wind...
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/133
Ovm3firefix: fixes for unit tests on Windows and for running management on Windows.
Some of the unit tests fail on Windows as File.separator was used, using it might seem like a good idea as suggested by Sonarcube, but all the paths generated with it are actually only run on Linux hosts as the agent for OVM3 runs on linux. So using the File.seperator is a real bad idea, not just for the tests but also for someone running the manager on a windows host.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuf/cloudstack ovm3firefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #133
----
commit d0e25d96fbdcce830795a5590afdf7f0e3302546
Author: Funs <fu...@barred.org>
Date: 2015-03-27T10:14:35Z
Fix paths so they also work with tests on windows.
Sonarcube is great, but has no context and can be wrong, in this
case File.separator is nice if you're running platform independent,
the agent on OVM3 is however NOT platform independent and will break
if we feed it windows separators.
commit e7d7643dd71b2175a8f553e1659141371c631656
Author: Funs <fu...@barred.org>
Date: 2015-03-27T10:19:16Z
Only one thing can come from the agent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Ovm3firefix: fixes for unit
tests on Wind...
Posted by Daan Hoogland <da...@gmail.com>.
sorry, i should learn to use pull requests
On Fri, Mar 27, 2015 at 12:01 PM, snuf <gi...@git.apache.org> wrote:
> Github user snuf commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/133#issuecomment-86900876
>
> That's what e7d7643 "Only one thing can come from the agent" commit is for :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
Daan
[GitHub] cloudstack pull request: Ovm3firefix: fixes for unit tests on Wind...
Posted by snuf <gi...@git.apache.org>.
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/133#issuecomment-86900876
That's what e7d7643 "Only one thing can come from the agent" commit is for :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Ovm3firefix: fixes for unit tests on Wind...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---