You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/18 06:41:34 UTC

[GitHub] [spark] HeartSaVioR opened a new pull request #24122: [MINOR][CORE] Add comment about reasoning to use deprecated Scala ForkJoinPool

HeartSaVioR opened a new pull request #24122: [MINOR][CORE] Add comment about reasoning to use deprecated Scala ForkJoinPool
URL: https://github.com/apache/spark/pull/24122
 
 
   ## What changes were proposed in this pull request?
   
   This is a derived patch from #24113.
   
   This patch proposes to add comment about reasoning why we keep using deprecated Scala ForkJoinPool even Spark 3.0.0 supports Scala 2.12. The origin intention was disabling deprecation warning, but Scala doesn't seem to have equivalent one for `@Suppresswarnings` for Java, so ended up just adding comment to make the intention clear.
   
   ## How was this patch tested?
   
   This is a minor change which would be expected to work same as it was, so Jenkins test would be enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org