You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <ch...@gmail.com> on 2005/08/19 15:29:43 UTC
svn_client_commit_item_t.revision reused for different things
Hi!
I am working on wc-replacement branch and notice strange thing:
In file subversion\include\libsvn_client.h line 270:
/** The commit candidate structure. */
typedef struct svn_client_commit_item_t
{
[..skip..]
/** revision (copyfrom-rev if _IS_COPY) */
svn_revnum_t revision;
/** copyfrom-url */
const char *copyfrom_url;
[..skip..]
} svn_client_commit_item_t;
As comment states member revision used as base revision and
copyfrom-revision, depending on copyfrom-url. For what is it? In
situation replace from copy, repository need to know original file
revision (for delete it) and copyfrom revision (for copy). I suggest
add separate member copyfrom_rev and get rid ambiguity.
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_client_commit_item_t.revision reused for different things
Posted by Ivan Zhakov <ch...@gmail.com>.
On 22 Aug 2005 15:11:41 -0500, kfogel@collab.net <kf...@collab.net> wrote:
> "C. Michael Pilato" <cm...@collab.net> writes:
> > Ivan Zhakov <ch...@gmail.com> writes:
> > > As comment states member revision used as base revision and
> > > copyfrom-revision, depending on copyfrom-url. For what is it? In
> > > situation replace from copy, repository need to know original file
> > > revision (for delete it) and copyfrom revision (for copy). I suggest
> > > add separate member copyfrom_rev and get rid ambiguity.
> >
> > +1. Makes sense. Knock yerself out.
> ^^^^^^^^^^^^^^^^^
>
> Ivan, I don't know how good your command of American idiom is :-). In
> case you don't know: "knock yerself out" just means "go for it".
Karl, thank you! I have spent 10 minutes for "decoding" this. Thanks
for explanations. Now I know by one American idiom more :-)
As you probably saw, I have already posted patch and waiting for
review: http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=104436
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_client_commit_item_t.revision reused for different things
Posted by kf...@collab.net.
"C. Michael Pilato" <cm...@collab.net> writes:
> Ivan Zhakov <ch...@gmail.com> writes:
>
> > Hi!
> > I am working on wc-replacement branch and notice strange thing:
> > In file subversion\include\libsvn_client.h line 270:
> > /** The commit candidate structure. */
> > typedef struct svn_client_commit_item_t
> > {
> > [..skip..]
> > /** revision (copyfrom-rev if _IS_COPY) */
> > svn_revnum_t revision;
> >
> > /** copyfrom-url */
> > const char *copyfrom_url;
> > [..skip..]
> > } svn_client_commit_item_t;
> >
> > As comment states member revision used as base revision and
> > copyfrom-revision, depending on copyfrom-url. For what is it? In
> > situation replace from copy, repository need to know original file
> > revision (for delete it) and copyfrom revision (for copy). I suggest
> > add separate member copyfrom_rev and get rid ambiguity.
>
> +1. Makes sense. Knock yerself out.
^^^^^^^^^^^^^^^^^
Ivan, I don't know how good your command of American idiom is :-). In
case you don't know: "knock yerself out" just means "go for it".
-Karl
--
www.collab.net <> CollabNet | Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_client_commit_item_t.revision reused for different things
Posted by "C. Michael Pilato" <cm...@collab.net>.
Ivan Zhakov <ch...@gmail.com> writes:
> Hi!
> I am working on wc-replacement branch and notice strange thing:
> In file subversion\include\libsvn_client.h line 270:
> /** The commit candidate structure. */
> typedef struct svn_client_commit_item_t
> {
> [..skip..]
> /** revision (copyfrom-rev if _IS_COPY) */
> svn_revnum_t revision;
>
> /** copyfrom-url */
> const char *copyfrom_url;
> [..skip..]
> } svn_client_commit_item_t;
>
> As comment states member revision used as base revision and
> copyfrom-revision, depending on copyfrom-url. For what is it? In
> situation replace from copy, repository need to know original file
> revision (for delete it) and copyfrom revision (for copy). I suggest
> add separate member copyfrom_rev and get rid ambiguity.
+1. Makes sense. Knock yerself out.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org