You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "baomingyu (via GitHub)" <gi...@apache.org> on 2026/01/15 01:35:11 UTC
[PR] [INLONG-12065][Sort] Sort Format supports outputting complete row information when field parsing errors occur. [inlong]
baomingyu opened a new pull request, #12066:
URL: https://github.com/apache/inlong/pull/12066
Fixes #12065
### Modifications
modifications like this
` try {
return ((BasicFormatInfo<?>) fieldFormatInfo).deserialize(fieldText);
} catch (Exception e) {
if (failureHandler != null) {
failureHandler.onConvertingFieldFailure(fieldName, fieldText, fieldFormatInfo,
head, inLongMsgBody, originBody, e);
} else {
LOG.warn("Could not properly deserialize the" + "text: {},for field:{}"
+ ". predefinedFields = {},fields = {}, attr={}, originBody={}",
fieldText, fieldName,
head == null ? "" : head.getPredefinedFields(),
inLongMsgBody == null ? "" : inLongMsgBody.getFields(),
head == null ? "" : head.getAttributes(),
originBody == null ? (inLongMsgBody == null ? "" : new String(inLongMsgBody.getDataBytes()))
: originBody,
e);
}
}`
When defining the failureHandler, the output shall be generated through onConvertingFieldFailure if it is implemented; otherwise, the output shall be written to the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-12065][Sort] Sort Format supports outputting complete row information when field parsing errors occur. [inlong]
Posted by "baomingyu (via GitHub)" <gi...@apache.org>.
baomingyu merged PR #12066:
URL: https://github.com/apache/inlong/pull/12066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-12065][Sort] Sort Format supports outputting complete row information when field parsing errors occur. [inlong]
Posted by "baomingyu (via GitHub)" <gi...@apache.org>.
baomingyu commented on code in PR #12066:
URL: https://github.com/apache/inlong/pull/12066#discussion_r2696759841
##########
inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/InLongMsgBody.java:
##########
@@ -25,14 +28,20 @@
/**
* The body deserialized from {@link InLongMsgBody}.
*/
+@Data
public class InLongMsgBody implements Serializable {
private static final long serialVersionUID = 1L;
/**
* The body of the record.
*/
- private final byte[] data;
+ private final byte[] dataBytes;
Review Comment:
InLongMsgBody is used internally when parsing messages, and there are no compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-12065][Sort] Sort Format supports outputting complete row information when field parsing errors occur. [inlong]
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #12066:
URL: https://github.com/apache/inlong/pull/12066#discussion_r2696717487
##########
inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/InLongMsgBody.java:
##########
@@ -25,14 +28,20 @@
/**
* The body deserialized from {@link InLongMsgBody}.
*/
+@Data
public class InLongMsgBody implements Serializable {
private static final long serialVersionUID = 1L;
/**
* The body of the record.
*/
- private final byte[] data;
+ private final byte[] dataBytes;
Review Comment:
seems to be a compatibility issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org