You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by foxish <gi...@git.apache.org> on 2018/01/18 21:17:23 UTC
[GitHub] spark pull request #20322: [SPARK-23133][K8S] Fix passing java options to Ex...
GitHub user foxish opened a pull request:
https://github.com/apache/spark/pull/20322
[SPARK-23133][K8S] Fix passing java options to Executor
## What changes were proposed in this pull request?
Supersedes https://github.com/apache/spark/pull/20296 and targets master.
cc/ @andrusha @vanzin @jiangxb1987
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Manual test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/foxish/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20322
----
commit 903179c8d485bcfce3e4918ba68cc99b72b6f377
Author: Anirudh Ramanathan <ra...@...>
Date: 2018-01-18T21:15:29Z
[SPARK-23133][K8S] Fix passing java options to Executor
Supersedes https://github.com/apache/spark/pull/20296
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20322
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/13/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20322
Merging to master / 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20322
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20322
Could you copy the title / description from the other PR instead of referencing it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20322
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20322
(And also add "Closes #20296" so that it's automatically closed when we push this.)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20322: [SPARK-23133][K8S] Fix passing java options to Ex...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20322
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20322
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86356/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20322
**[Test build #86356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86356/testReport)** for PR 20322 at commit [`903179c`](https://github.com/apache/spark/commit/903179c8d485bcfce3e4918ba68cc99b72b6f377).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20322
**[Test build #86356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86356/testReport)** for PR 20322 at commit [`903179c`](https://github.com/apache/spark/commit/903179c8d485bcfce3e4918ba68cc99b72b6f377).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20322
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20322
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org