You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/11 12:11:18 UTC
[GitHub] [pulsar] jianyun8023 opened a new pull request #8038: SinkRecord adds an overridden method
jianyun8023 opened a new pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038
### Motivation
When I was writing the io connector, I needed to use `Message` in the sink, but `SinkRecord` did not implement the `getMessage` method.
### Modifications
Add the implementation of `getMessage` and `getEventTime` to `SinkRecord`.
### Verifying this change
Not needed》
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691515742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691840587
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691515742
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-692832866
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691515742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-692702088
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-692760642
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-693368812
@gaoran10 @codelipenghui Please help me review the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-693308378
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-692212123
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691786105
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-691696093
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8038: SinkRecord adds an overridden method
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8038:
URL: https://github.com/apache/pulsar/pull/8038#issuecomment-718333608
need to cherry-pick to 2.6.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org