You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (Commented) (JIRA)" <ji...@apache.org> on 2012/02/23 07:09:48 UTC
[jira] [Commented] (HBASE-5455) Add test to avoid unintentional
reordering of items in HbaseObjectWritable
[ https://issues.apache.org/jira/browse/HBASE-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214352#comment-13214352 ]
stack commented on HBASE-5455:
------------------------------
Good idea.
> Add test to avoid unintentional reordering of items in HbaseObjectWritable
> --------------------------------------------------------------------------
>
> Key: HBASE-5455
> URL: https://issues.apache.org/jira/browse/HBASE-5455
> Project: HBase
> Issue Type: Test
> Reporter: Michael Drzal
> Priority: Minor
> Fix For: 0.94.0
>
>
> HbaseObjectWritable has a static initialization block that assigns ints to various classes. The int is assigned by using a local variable that is incremented after each use. If someone adds a line in the middle of the block, this throws off everything after the change, and can break client compatibility. There is already a comment to not add/remove lines at the beginning of this block. It might make sense to have a test against a static set of ids. If something gets changed unintentionally, it would at least fail the tests. If the change was intentional, at the very least the test would need to get updated, and it would be a conscious decision.
> https://issues.apache.org/jira/browse/HBASE-5204 contains the the fix for one issue of this type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira