You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2018/07/31 17:56:16 UTC

[GitHub] spark pull request #21934: [SPARK-24951][SQL] Table valued functions should ...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/21934

    [SPARK-24951][SQL] Table valued functions should throw AnalysisException

    ## What changes were proposed in this pull request?
    Previously TVF resolution could throw IllegalArgumentException if the data type is null type. This patch replaces that exception with AnalysisException, enriched with positional information, to improve error message reporting and to be more consistent with rest of Spark SQL.
    
    ## How was this patch tested?
    Updated the test case in table-valued-functions.sql.out, which is how I identified this problem in the first place.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-24951

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21934
    
----
commit 08a6b7fc1d2a1a6149c4da2ca1657258347fd18f
Author: Reynold Xin <rx...@...>
Date:   2018-07-31T17:47:55Z

    [SPARK-24951][SQL] Table valued functions should throw AnalysisException

commit 514fd77501194e43e8029734e4a3669f12fbf749
Author: Reynold Xin <rx...@...>
Date:   2018-07-31T17:53:21Z

    Improve error message

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21934: [SPARK-24951][SQL] Table valued functions should ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21934


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    **[Test build #93834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93834/testReport)** for PR 21934 at commit [`514fd77`](https://github.com/apache/spark/commit/514fd77501194e43e8029734e4a3669f12fbf749).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by holdensmagicalunicorn <gi...@git.apache.org>.
Github user holdensmagicalunicorn commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    @rxin, thanks! I am a bot who has found some folks who might be able to help with the review:@hvanhovell, @cloud-fan and @gatorsmile


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21934: [SPARK-24951][SQL] Table valued functions should ...

Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21934#discussion_r206680796
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out ---
    @@ -83,8 +83,13 @@ select * from range(1, null)
     -- !query 6 schema
     struct<>
     -- !query 6 output
    -java.lang.IllegalArgumentException
    -Invalid arguments for resolved function: 1, null
    +org.apache.spark.sql.AnalysisException
    +error: table-valued function range with alternatives:
    --- End diff --
    
    @rxin will it be better to display the function name within single quotes ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    **[Test build #93849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93849/testReport)** for PR 21934 at commit [`514fd77`](https://github.com/apache/spark/commit/514fd77501194e43e8029734e4a3669f12fbf749).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21934: [SPARK-24951][SQL] Table valued functions should ...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21934#discussion_r206681479
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out ---
    @@ -83,8 +83,13 @@ select * from range(1, null)
     -- !query 6 schema
     struct<>
     -- !query 6 output
    -java.lang.IllegalArgumentException
    -Invalid arguments for resolved function: 1, null
    +org.apache.spark.sql.AnalysisException
    +error: table-valued function range with alternatives:
    --- End diff --
    
    probably could go either way


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    **[Test build #93834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93834/testReport)** for PR 21934 at commit [`514fd77`](https://github.com/apache/spark/commit/514fd77501194e43e8029734e4a3669f12fbf749).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93849/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1523/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1535/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21934: [SPARK-24951][SQL] Table valued functions should ...

Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21934#discussion_r206682497
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out ---
    @@ -83,8 +83,13 @@ select * from range(1, null)
     -- !query 6 schema
     struct<>
     -- !query 6 output
    -java.lang.IllegalArgumentException
    -Invalid arguments for resolved function: 1, null
    +org.apache.spark.sql.AnalysisException
    +error: table-valued function range with alternatives:
    --- End diff --
    
    @rxin Ok.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93834/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by ericl <gi...@git.apache.org>.
Github user ericl commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    **[Test build #93849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93849/testReport)** for PR 21934 at commit [`514fd77`](https://github.com/apache/spark/commit/514fd77501194e43e8029734e4a3669f12fbf749).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    cc @gatorsmile @ericl who originally wrote this.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21934: [SPARK-24951][SQL] Table valued functions should throw A...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/21934
  
    Jenkins, retest this please.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org