[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8514: [fix] cluster_name = cluster_name, not cluster_id
URL: https://github.com/apache/incubator-superset/pull/8514#discussion_r345957178
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -1612,7 +1612,7 @@ def query_datasources_by_name(
     ) -> List["DruidDatasource"]:
         return (
             session.query(cls)
-            .filter_by(cluster_name=database.id)
+            .filter_by(cluster_name=database.database_name)
 
 Review comment:
   Mmmh, for reference, this came from #2497.
   
   Clearly there are issues around the Connector interface. Good news is we're planning on deprecating the Druid connector in favor of SQLAlchemy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org