You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/22 14:11:20 UTC
[GitHub] [spark-website] maropu opened a new pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
maropu opened a new pull request #286:
URL: https://github.com/apache/spark-website/pull/286
This PR adds descriptions about how to run tests in a forked repository using GitHub Actions.
This comes from https://github.com/apache/spark/pull/29504.
<img width="700" alt="Screen Shot 2020-08-22 at 23 03 19" src="https://user-images.githubusercontent.com/692303/90958036-6c520f80-e4cc-11ea-8bc4-f1602bd45bf4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475139695
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started using some action scripts and one of them is to run tests for Pull Requests.
Review comment:
Sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475145735
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started using some action scripts and one of them is to run tests for Pull Requests.
Review comment:
Looks like we don't have the direct link to the secion, so I added the link to the page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HyukjinKwon commented on pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #286:
URL: https://github.com/apache/spark-website/pull/286#issuecomment-678645993
+1 nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097094
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
Review comment:
suggestion: `before creating it` -> `before creating the Pull Request`
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
Review comment:
nit: `Reques` -> `Request`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097170
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
Review comment:
nit: `run` -> `runs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097318
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
+
+Our script enables you to run tests for a branch in your forked repository.
+Let's say that you have a branch named "your_branch" for a Pull Request.
+To run tests on "your_branch" and check test reuslts:
Review comment:
nit: `reuslts` -> `results`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475096904
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
+
+Our script enables you to run tests for a branch in your forked repository.
+Let's say that you have a branch named "your_branch" for a Pull Request.
+To run tests on "your_branch" and check test reuslts:
+
+- Clicks a "Actions" tab in your forked repository.
+- Selects a "Build and test" workfolow in a "All workflows" list.
+- Pushs a "Run workflow" button and enters "your_branch" in a "Target branch to run" field.
+- When a "Build and test" workflow finished, clicks a "Report test results" workfolow to check test results.
Review comment:
nit: `workfolow` -> `workflow`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] dongjoon-hyun commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475105278
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started using some action scripts and one of them is to run tests for Pull Requests.
Review comment:
This looks good. Could you add some link to this from `Pull Request` section in https://spark.apache.org/contributing.html?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475098802
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
Review comment:
How about this? Now, it looks that `our ... script ... run ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #286:
URL: https://github.com/apache/spark-website/pull/286#issuecomment-678653902
Looks good to me. Hope someone does another pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097900
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
+
+Our script enables you to run tests for a branch in your forked repository.
+Let's say that you have a branch named "your_branch" for a Pull Request.
+To run tests on "your_branch" and check test reuslts:
+
+- Clicks a "Actions" tab in your forked repository.
+- Selects a "Build and test" workfolow in a "All workflows" list.
+- Pushs a "Run workflow" button and enters "your_branch" in a "Target branch to run" field.
+- When a "Build and test" workflow finished, clicks a "Report test results" workfolow to check test results.
Review comment:
Ah, thanks! I forgot to run a typo checker. I run it by myself and pushed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097248
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
Review comment:
How about adding rough number of limited resources?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097900
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
+
+Our script enables you to run tests for a branch in your forked repository.
+Let's say that you have a branch named "your_branch" for a Pull Request.
+To run tests on "your_branch" and check test reuslts:
+
+- Clicks a "Actions" tab in your forked repository.
+- Selects a "Build and test" workfolow in a "All workflows" list.
+- Pushs a "Run workflow" button and enters "your_branch" in a "Target branch to run" field.
+- When a "Build and test" workflow finished, clicks a "Report test results" workfolow to check test results.
Review comment:
Ah, thanks! I forgot to run a typo checker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #286:
URL: https://github.com/apache/spark-website/pull/286#issuecomment-678645862
cc: @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097047
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
Review comment:
nit: `Reques` -> `Requests`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475096996
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
Review comment:
nit: `uing` -> `using`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475097470
##########
File path: site/developer-tools.html
##########
@@ -406,6 +406,27 @@ <h4>Testing K8S</h4>
<p>Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don’t hesitate to file a Jira issue.</p>
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+<p>GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
Review comment:
ditto at Lines 412-415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] asfgit closed pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #286:
URL: https://github.com/apache/spark-website/pull/286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475099245
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
Review comment:
I saw the max number, 180, in https://issues.apache.org/jira/browse/SPARK-32264?focusedCommentId=17170040&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17170040
But, this number might change in future, so I think it the current statement is okay for most developers.
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
Review comment:
I saw the max number, 180, in https://issues.apache.org/jira/browse/SPARK-32264?focusedCommentId=17170040&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17170040 But, this number might change in future, so I think it the current statement is okay for most developers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] kiszk commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475099515
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
+this can burden our limited resources of GitHub Actions.
Review comment:
I see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on a change in pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #286:
URL: https://github.com/apache/spark-website/pull/286#discussion_r475099316
##########
File path: developer-tools.md
##########
@@ -228,6 +228,25 @@ Getting logs from the pods and containers directly is an exercise left to the re
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
+<h3>Running tests in your forked repository using GitHub Actions</h3>
+
+GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
+We have already started uing some action scripts and one of them is to run tests for Pull Requests.
+If you are planning to create a new Pull Reques, it is important to check if tests can pass on your branch before creating it.
+This is because our GitHub Acrions script automatically run tests for your Pull Request/following commits and
Review comment:
Yea, in the following commit, I've updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] maropu commented on pull request #286: Add descriptions about GitHub Actions in the "Useful Developer Tools" page
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #286:
URL: https://github.com/apache/spark-website/pull/286#issuecomment-678762858
Thanks, all! Merged to asf-site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org