You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/29 09:05:06 UTC
[GitHub] [dubbo-go-pixiu] yqxu opened a new pull request #310: using trie enhance dubbo route.go
yqxu opened a new pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310
using trie enhance dubbo route.go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] yqxu commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
yqxu commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r767250197
##########
File path: pkg/router/route.go
##########
@@ -26,131 +26,117 @@ import (
import (
"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config"
"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/router"
-
- "github.com/emirpasic/gods/trees/avltree"
-
"github.com/pkg/errors"
)
import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/router/trie"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
)
// Node defines the single method of the router configured API
type Node struct {
fullPath string
- wildcard bool
filters []string
- methods map[config.HTTPVerb]*config.Method
+ method *config.Method
headers map[string]string
}
// Route defines the tree of router APIs
type Route struct {
- lock sync.RWMutex
- tree *avltree.Tree
- wildcardTree *avltree.Tree
+ lock sync.RWMutex
+ tree trie.Trie
}
// ClearAPI clear the api
func (rt *Route) ClearAPI() error {
rt.lock.Lock()
defer rt.lock.Unlock()
- rt.wildcardTree.Clear()
rt.tree.Clear()
return nil
}
func (r *Route) RemoveAPI(api router.API) {
- fullPath := api.URLPattern
- node, ok := r.findNode(fullPath)
- if !ok {
- return
- }
- if tempMethod, ok := node.methods[api.HTTPVerb]; ok {
- splitedURLs := strings.Split(tempMethod.IntegrationRequest.HTTPBackendConfig.URL, ",")
- afterRemoveedURL := make([]string, 0, len(splitedURLs))
- for _, v := range splitedURLs {
- if v != api.IntegrationRequest.HTTPBackendConfig.URL {
- afterRemoveedURL = append(afterRemoveedURL, v)
- }
- }
- if len(afterRemoveedURL) == 0 {
- delete(node.methods, api.HTTPVerb)
+ lowerCasePath := strings.ToLower(api.URLPattern)
+ key := getTrieKey(api.Method.HTTPVerb, lowerCasePath, false)
+ _, _ = r.tree.Remove(key)
Review comment:
thx 需要的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b9593a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/737b896076f498182f2a1dd9401932d6f768da1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (737b896) will **decrease** coverage by `0.10%`.
> The diff coverage is `61.44%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
- Coverage 36.10% 35.99% -0.11%
===========================================
Files 55 55
Lines 3293 3303 +10
===========================================
Hits 1189 1189
- Misses 1985 1992 +7
- Partials 119 122 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `67.02% <0.00%> (-4.17%)` | :arrow_down: |
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `66.96% <70.58%> (+0.29%)` | :arrow_up: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [737b896...4b9593a](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5499710) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/bf6dde05c14d394a5f6bda919fc6473107ae8d25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf6dde0) will **increase** coverage by `0.42%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 36.04% 36.46% +0.42%
===========================================
Files 55 55
Lines 3299 3310 +11
===========================================
+ Hits 1189 1207 +18
+ Misses 1991 1981 -10
- Partials 119 122 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `66.96% <70.58%> (+0.29%)` | :arrow_up: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `76.19% <100.00%> (+5.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf6dde0...5499710](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur merged pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
ztelur merged pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r759896373
##########
File path: pkg/router/route_test.go
##########
@@ -99,72 +92,73 @@ func TestFindMethod(t *testing.T) {
e = rt.PutAPI(router.API{URLPattern: "/vought/:id/supe/:name", Method: n1})
assert.Nil(t, e)
- m, ok := rt.FindAPI("/theboys", config.MethodGet)
+ m, ok := rt.MatchAPI("/theboys", config.MethodGet)
assert.True(t, ok)
assert.NotNil(t, m)
assert.Equal(t, m.URLPattern, "/theboys")
- m, ok = rt.FindAPI("/theboys", config.MethodPost)
+ m, ok = rt.MatchAPI("/theboys", config.MethodPost)
assert.False(t, ok)
assert.Nil(t, m)
- m, ok = rt.FindAPI("/vought/123/supe/startlight", config.MethodPost)
+ m, ok = rt.MatchAPI("/vought/123/supe/startlight", config.MethodPost)
assert.True(t, ok)
assert.NotNil(t, m)
assert.Equal(t, m.URLPattern, "/vought/:id/supe/:name")
- m, ok = rt.FindAPI("/vought/123/supe/startlight", config.MethodPost)
+ m, ok = rt.MatchAPI("/vought/123/supe/startlight", config.MethodPost)
assert.True(t, ok)
assert.NotNil(t, m)
assert.Equal(t, m.URLPattern, "/vought/:id/supe/:name")
}
-func TestUpdateMethod(t *testing.T) {
- m0 := getMockMethod(config.MethodGet)
- m1 := getMockMethod(config.MethodGet)
- m0.DubboBackendConfig.Version = "1.0.0"
- m1.DubboBackendConfig.Version = "2.0.0"
-
- rt := NewRoute()
- rt.PutAPI(router.API{URLPattern: "/marvel", Method: m0})
- m, _ := rt.FindAPI("/marvel", config.MethodGet)
- assert.Equal(t, m.DubboBackendConfig.Version, "1.0.0")
- rt.UpdateAPI(router.API{URLPattern: "/marvel", Method: m1})
- m, ok := rt.FindAPI("/marvel", config.MethodGet)
- assert.True(t, ok)
- assert.Equal(t, m.DubboBackendConfig.Version, "2.0.0")
-
- rt.PutAPI(router.API{URLPattern: "/theboys/:id", Method: m0})
- m, _ = rt.FindAPI("/theBoys/12345", config.MethodGet)
- assert.Equal(t, m.DubboBackendConfig.Version, "1.0.0")
- rt.UpdateAPI(router.API{URLPattern: "/theBoys/:id", Method: m1})
- m, ok = rt.FindAPI("/theBoys/12345", config.MethodGet)
- assert.True(t, ok)
- assert.Equal(t, m.DubboBackendConfig.Version, "2.0.0")
-}
-
-func TestSearchWildcard(t *testing.T) {
- rt := &Route{
- tree: avltree.NewWithStringComparator(),
- wildcardTree: avltree.NewWithStringComparator(),
- }
- n0 := getMockMethod(config.MethodGet)
- e := rt.PutAPI(router.API{URLPattern: "/theboys", Method: n0})
- assert.Nil(t, e)
- e = rt.PutAPI(router.API{URLPattern: "/theboys/:id", Method: n0})
- assert.Nil(t, e)
- e = rt.PutAPI(router.API{URLPattern: "/vought/:id/supe/:name", Method: n0})
- assert.Nil(t, e)
-
- _, ok := rt.searchWildcard("/marvel")
- assert.False(t, ok)
- _, ok = rt.searchWildcard("/theboys/:id/age")
- assert.False(t, ok)
- _, ok = rt.searchWildcard("/theboys/butcher")
- assert.True(t, ok)
- _, ok = rt.searchWildcard("/vought/:id/supe/homelander")
- assert.True(t, ok)
-}
+//
+//func TestUpdateMethod(t *testing.T) {
Review comment:
确定无用了吗？无用就删掉。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r769162889
##########
File path: pkg/common/util/stringutil/stringutil.go
##########
@@ -72,14 +72,19 @@ func IsMatchAll(key string) bool {
func GetTrieKey(method string, path string) string {
ret := ""
+ //"http://localhost:8882/api/v1/test-dubbo/user?name=tc"
+ if strings.Contains(path, constant.ProtocolSlash) {
+ path = path[strings.Index(path, constant.ProtocolSlash)+len(constant.ProtocolSlash):]
+ path = path[strings.Index(path, constant.PathSlash)+1:]
+ }
if strings.HasPrefix(path, constant.PathSlash) {
ret = method + path
} else {
ret = method + constant.PathSlash + path
}
-
if strings.HasSuffix(ret, constant.PathSlash) {
ret = ret[0 : len(ret)-1]
}
+ ret = strings.Split(ret, "?")[0]
Review comment:
is it better to make "?" as a constant named variable? code in trie.go uses "?" too
##########
File path: pkg/common/router/trie/trie.go
##########
@@ -18,12 +18,13 @@
package trie
import (
- "github.com/pkg/errors"
+ "strings"
)
import (
"github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
"github.com/apache/dubbo-go-pixiu/pkg/logger"
+ "github.com/pkg/errors"
Review comment:
please split third party import to another import block,like below.
import (
"github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
"github.com/apache/dubbo-go-pixiu/pkg/logger"
)
import (
"github.com/pkg/errors""
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d32d22) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/81c51fdd305abf20f66a60c0649496413a7e48d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81c51fd) will **increase** coverage by `0.28%`.
> The diff coverage is `72.28%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 36.52% 36.80% +0.28%
===========================================
Files 54 54
Lines 3253 3260 +7
===========================================
+ Hits 1188 1200 +12
+ Misses 1945 1937 -8
- Partials 120 123 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `65.78% <69.44%> (-0.88%)` | :arrow_down: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.40% <100.00%> (+4.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [81c51fd...3d32d22](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5499710) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/bf6dde05c14d394a5f6bda919fc6473107ae8d25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf6dde0) will **increase** coverage by `0.42%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 36.04% 36.46% +0.42%
===========================================
Files 55 55
Lines 3299 3310 +11
===========================================
+ Hits 1189 1207 +18
+ Misses 1991 1981 -10
- Partials 119 122 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `66.96% <70.58%> (+0.29%)` | :arrow_up: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `76.19% <100.00%> (+5.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf6dde0...5499710](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r759894913
##########
File path: pkg/common/router/trie/trie.go
##########
@@ -166,6 +172,17 @@ func (node *Node) internalPut(keys []string, bizInfo interface{}) (bool, error)
}
+func (node *Node) Clear() bool {
Review comment:
真是迂腐。'*node = Node{}' 一行代码 enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bf0084) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `0.28%`.
> The diff coverage is `72.28%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 36.52% 36.80% +0.28%
===========================================
Files 54 54
Lines 3253 3260 +7
===========================================
+ Hits 1188 1200 +12
+ Misses 1945 1937 -8
- Partials 120 123 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `65.78% <69.44%> (-0.88%)` | :arrow_down: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.40% <100.00%> (+4.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...2bf0084](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
ztelur commented on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-983190681
plz fix ci problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] PhilYue commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
PhilYue commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r759941650
##########
File path: pkg/router/route.go
##########
@@ -26,131 +26,117 @@ import (
import (
"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config"
"github.com/dubbogo/dubbo-go-pixiu-filter/pkg/router"
-
- "github.com/emirpasic/gods/trees/avltree"
-
"github.com/pkg/errors"
)
import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/router/trie"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
)
// Node defines the single method of the router configured API
type Node struct {
fullPath string
- wildcard bool
filters []string
- methods map[config.HTTPVerb]*config.Method
+ method *config.Method
headers map[string]string
}
// Route defines the tree of router APIs
type Route struct {
- lock sync.RWMutex
- tree *avltree.Tree
- wildcardTree *avltree.Tree
+ lock sync.RWMutex
+ tree trie.Trie
}
// ClearAPI clear the api
func (rt *Route) ClearAPI() error {
rt.lock.Lock()
defer rt.lock.Unlock()
- rt.wildcardTree.Clear()
rt.tree.Clear()
return nil
}
func (r *Route) RemoveAPI(api router.API) {
- fullPath := api.URLPattern
- node, ok := r.findNode(fullPath)
- if !ok {
- return
- }
- if tempMethod, ok := node.methods[api.HTTPVerb]; ok {
- splitedURLs := strings.Split(tempMethod.IntegrationRequest.HTTPBackendConfig.URL, ",")
- afterRemoveedURL := make([]string, 0, len(splitedURLs))
- for _, v := range splitedURLs {
- if v != api.IntegrationRequest.HTTPBackendConfig.URL {
- afterRemoveedURL = append(afterRemoveedURL, v)
- }
- }
- if len(afterRemoveedURL) == 0 {
- delete(node.methods, api.HTTPVerb)
+ lowerCasePath := strings.ToLower(api.URLPattern)
+ key := getTrieKey(api.Method.HTTPVerb, lowerCasePath, false)
+ _, _ = r.tree.Remove(key)
Review comment:
这里 remove 操作是否要加锁🔐 ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#discussion_r759895527
##########
File path: pkg/common/router/trie/trie_test.go
##########
@@ -18,7 +18,10 @@
package trie
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
Review comment:
这...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #310: using trie enhance dubbo route.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #310:
URL: https://github.com/apache/dubbo-go-pixiu/pull/310#issuecomment-981464108
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#310](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61864b2) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/737b896076f498182f2a1dd9401932d6f768da1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (737b896) will **decrease** coverage by `0.15%`.
> The diff coverage is `61.90%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
- Coverage 36.10% 35.95% -0.16%
===========================================
Files 55 55
Lines 3293 3310 +17
===========================================
+ Hits 1189 1190 +1
- Misses 1985 1998 +13
- Partials 119 122 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `67.19% <8.33%> (-4.00%)` | :arrow_down: |
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `66.96% <70.58%> (+0.29%)` | :arrow_up: |
| [pkg/filter/http/apiconfig/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL2FwaWNvbmZpZy9hcGkvZGlzY292ZXJ5X3NlcnZpY2UuZ28=) | `42.42% <75.00%> (+1.01%)` | :arrow_up: |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [737b896...61864b2](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org