You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/06 08:22:03 UTC
[GitHub] [doris] cambyzju opened a new pull request, #15681: [fix](schema change) bugfix for light schema change while with rollup
cambyzju opened a new pull request, #15681:
URL: https://github.com/apache/doris/pull/15681
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/15593
## Problem summary
Describe your changes.
this problem come from pr: https://github.com/apache/doris/pull/11494
After add column to rollup index, it also change column UniqueId inside base index.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1376802336
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.5 seconds
load time: 481 seconds
storage size: 17122855324 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230110064354_clickbench_pr_76521.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1374986985
Please add some regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1376948084
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #15681:
URL: https://github.com/apache/doris/pull/15681#discussion_r1064662678
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1106,18 +1106,20 @@ private void checkAndAddColumn(List<Column> modIndexSchema, Column newColumn, Co
hasPos = true;
}
- newColumn.setUniqueId(newColumnUniqueId);
+ // newColumn may add to baseIndex or rollups, so we need copy before change UniqueId
Review Comment:
not support.
now rollup columns are subset of base table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1375690491
> Please add some regression tests.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15681:
URL: https://github.com/apache/doris/pull/15681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Lchangliang commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
Lchangliang commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1376920497
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #15681:
URL: https://github.com/apache/doris/pull/15681#discussion_r1064232485
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1106,18 +1106,20 @@ private void checkAndAddColumn(List<Column> modIndexSchema, Column newColumn, Co
hasPos = true;
}
- newColumn.setUniqueId(newColumnUniqueId);
+ // newColumn may add to baseIndex or rollups, so we need copy before change UniqueId
Review Comment:
Does doris support add a column to rollup and the column is not in base table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15681: [fix](schema change) bugfix for light schema change while with rollup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15681:
URL: https://github.com/apache/doris/pull/15681#issuecomment-1376948020
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org