[jira] [Commented] (ORC-158) do not assume an array-backed buffer in static ReaderImpl methods

["Prasanth Jayachandran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070733#comment-16070733 ] 

Prasanth Jayachandran commented on ORC-158:
-------------------------------------------

- if (bb.hasArray()) .. else.. can be put into a separate util method.. 
- Catch CharacterCodingException and wrap it inside FileFormatException with appropriate error msg. This way reader just throws FileFormatException if it can't read footer/ps etc.. 

> do not assume an array-backed buffer in static ReaderImpl methods
> -----------------------------------------------------------------
>
>                 Key: ORC-158
>                 URL: https://issues.apache.org/jira/browse/ORC-158
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: ORC-158.patch
>
>
> For example, arrayOffset() usage causes errors with direct buffers.
> Another useful thing to support would be an array of ByteBuffer-s, in case the read from e.g. ZCR, or cache, does not fit into one ByteBuffer, however unlikely that is



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)