You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by kp...@apache.org on 2012/06/08 16:59:06 UTC

svn commit: r1348098 - in /qpid/branches/asyncstore/cpp/src: ./ qpid/asyncStore/ qpid/broker/ tests/storePerftools/asyncPerf/

Author: kpvdr
Date: Fri Jun  8 14:59:04 2012
New Revision: 1348098

URL: http://svn.apache.org/viewvc?rev=1348098&view=rev
Log:
QPID-3858: WIP - completed async return path

Added:
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.cpp
      - copied, changed from r1347588, qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.h
      - copied, changed from r1347588, qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.h
Removed:
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.h
Modified:
    qpid/branches/asyncstore/cpp/src/CMakeLists.txt
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.cpp
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.h
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.cpp
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.h
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.cpp
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.h
    qpid/branches/asyncstore/cpp/src/qpid/asyncStore/Plugin.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp
    qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/ConfigHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/EnqueueHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/EventHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/MessageHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/QueueHandle.h
    qpid/branches/asyncstore/cpp/src/qpid/broker/TxnHandle.h
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MessageConsumer.cpp
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.cpp
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.h
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.cpp
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.h
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.cpp
    qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.h

Modified: qpid/branches/asyncstore/cpp/src/CMakeLists.txt
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/CMakeLists.txt?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/CMakeLists.txt (original)
+++ qpid/branches/asyncstore/cpp/src/CMakeLists.txt Fri Jun  8 14:59:04 2012
@@ -1078,7 +1078,7 @@ set (qpidbroker_SOURCES
      qpid/amqp_0_10/Connection.cpp
      qpid/broker/AsyncResultHandle.cpp
      qpid/broker/AsyncResultHandleImpl.cpp
-     qpid/broker/AsyncResultQueue.cpp
+     qpid/broker/AsyncResultQueueImpl.cpp
      qpid/broker/AsyncStore.cpp
      qpid/broker/Broker.cpp
      qpid/broker/Credit.cpp

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.cpp Fri Jun  8 14:59:04 2012
@@ -34,60 +34,50 @@ AsyncOperation::AsyncOperation() :
         m_op(NONE),
         m_targetHandle(),
         m_dataSrc(0),
-        m_txnHandle(0),
-        m_resCb(0),
-        m_brokerCtxt(0)
+        m_txnHandle(0)
 {}
 
 AsyncOperation::AsyncOperation(const opCode op,
                                const qpid::broker::IdHandle* th,
-                               const qpid::broker::ResultCallback resCb,
-                               qpid::broker::BrokerAsyncContext* brokerCtxt) :
+                               boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt) :
         m_op(op),
         m_targetHandle(th),
         m_dataSrc(0),
         m_txnHandle(0),
-        m_resCb(resCb),
         m_brokerCtxt(brokerCtxt)
 {}
 
 AsyncOperation::AsyncOperation(const opCode op,
                                const qpid::broker::IdHandle* th,
-                               const qpid::broker::DataSource* dataSrc,
-                               const qpid::broker::ResultCallback resCb,
-                               qpid::broker::BrokerAsyncContext* brokerCtxt) :
+                               const qpid::broker::DataSource* const dataSrc,
+                               boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt) :
         m_op(op),
         m_targetHandle(th),
         m_dataSrc(dataSrc),
         m_txnHandle(0),
-        m_resCb(resCb),
         m_brokerCtxt(brokerCtxt)
 {}
 
 AsyncOperation::AsyncOperation(const opCode op,
                                const qpid::broker::IdHandle* th,
                                const qpid::broker::TxnHandle* txnHandle,
-                               const qpid::broker::ResultCallback resCb,
-                               qpid::broker::BrokerAsyncContext* brokerCtxt) :
+                               boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt) :
         m_op(op),
         m_targetHandle(th),
         m_dataSrc(0),
         m_txnHandle(txnHandle),
-        m_resCb(resCb),
         m_brokerCtxt(brokerCtxt)
 {}
 
 AsyncOperation::AsyncOperation(const opCode op,
                                const qpid::broker::IdHandle* th,
-                               const qpid::broker::DataSource* dataSrc,
+                               const qpid::broker::DataSource* const dataSrc,
                                const qpid::broker::TxnHandle* txnHandle,
-                               const qpid::broker::ResultCallback resCb,
-                               qpid::broker::BrokerAsyncContext* brokerCtxt) :
+                               boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt) :
         m_op(op),
         m_targetHandle(th),
         m_dataSrc(dataSrc),
         m_txnHandle(txnHandle),
-        m_resCb(resCb),
         m_brokerCtxt(brokerCtxt)
 {}
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncOperation.h Fri Jun  8 14:59:04 2012
@@ -50,34 +50,29 @@ public:
     AsyncOperation();
     AsyncOperation(const opCode op,
                    const qpid::broker::IdHandle* th,
-                   const qpid::broker::ResultCallback resCb,
-                   qpid::broker::BrokerAsyncContext* brokerCtxt);
+                   boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     AsyncOperation(const opCode op,
                    const qpid::broker::IdHandle* th,
-                   const qpid::broker::DataSource* dataSrc,
-                   const qpid::broker::ResultCallback resCb,
-                   qpid::broker::BrokerAsyncContext* brokerCtxt);
+                   const qpid::broker::DataSource* const dataSrc,
+                   boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     AsyncOperation(const opCode op,
                    const qpid::broker::IdHandle* th,
                    const qpid::broker::TxnHandle* txnHandle,
-                   const qpid::broker::ResultCallback resCb,
-                   qpid::broker::BrokerAsyncContext* brokerCtxt);
+                   boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     AsyncOperation(const opCode op,
                    const qpid::broker::IdHandle* th,
-                   const qpid::broker::DataSource* dataSrc,
+                   const qpid::broker::DataSource* const dataSrc,
                    const qpid::broker::TxnHandle* txnHandle,
-                   const qpid::broker::ResultCallback resCb,
-                   qpid::broker::BrokerAsyncContext* brokerCtxt);
+                   boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     virtual ~AsyncOperation();
     const char* getOpStr() const;
     static const char* getOpStr(const opCode op);
 
     opCode m_op;
     const qpid::broker::IdHandle* m_targetHandle;
-    const qpid::broker::DataSource* m_dataSrc;
+    const qpid::broker::DataSource* const m_dataSrc;
     const qpid::broker::TxnHandle* m_txnHandle;
-    const qpid::broker::ResultCallback m_resCb;
-    qpid::broker::BrokerAsyncContext* m_brokerCtxt;
+    boost::shared_ptr<qpid::broker::BrokerAsyncContext> const m_brokerCtxt;
 };
 
 }} // namespace qpid::asyncStore

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.cpp Fri Jun  8 14:59:04 2012
@@ -38,12 +38,11 @@ namespace qpid {
 namespace asyncStore {
 
 AsyncStoreImpl::AsyncStoreImpl(boost::shared_ptr<qpid::sys::Poller> poller,
-                               const AsyncStoreOptions& opts,
-                               qpid::broker::AsyncResultQueue* resultQueue) :
+                               const AsyncStoreOptions& opts) :
         m_poller(poller),
         m_opts(opts),
         m_runState(),
-        m_operations(m_poller, resultQueue)
+        m_operations(m_poller)
 {}
 
 AsyncStoreImpl::~AsyncStoreImpl()
@@ -63,23 +62,17 @@ void
 AsyncStoreImpl::initManagement(qpid::broker::Broker* /*broker*/)
 {}
 
-qpid::broker::TxnHandle
-AsyncStoreImpl::createTxnHandle(const std::string& xid)
-{
-    return qpid::broker::TxnHandle(new TxnHandleImpl(xid));
-}
-
 qpid::broker::ConfigHandle
 AsyncStoreImpl::createConfigHandle()
 {
     return qpid::broker::ConfigHandle(new ConfigHandleImpl());
 }
 
-qpid::broker::QueueHandle
-AsyncStoreImpl::createQueueHandle(const std::string& name,
-                                  const qpid::types::Variant::Map& opts)
+qpid::broker::EnqueueHandle
+AsyncStoreImpl::createEnqueueHandle(qpid::broker::MessageHandle& msgHandle,
+                                    qpid::broker::QueueHandle& queueHandle)
 {
-    return qpid::broker::QueueHandle(new QueueHandleImpl(name, opts));
+    return qpid::broker::EnqueueHandle(new EnqueueHandleImpl(msgHandle, queueHandle));
 }
 
 qpid::broker::EventHandle
@@ -90,202 +83,178 @@ AsyncStoreImpl::createEventHandle(qpid::
 }
 
 qpid::broker::MessageHandle
-AsyncStoreImpl::createMessageHandle(const qpid::broker::DataSource* dataSrc)
+AsyncStoreImpl::createMessageHandle(const qpid::broker::DataSource* const dataSrc)
 
 {
     return qpid::broker::MessageHandle(new MessageHandleImpl(dataSrc));
 }
 
-qpid::broker::EnqueueHandle
-AsyncStoreImpl::createEnqueueHandle(qpid::broker::MessageHandle& msgHandle,
-                                    qpid::broker::QueueHandle& queueHandle)
+qpid::broker::QueueHandle
+AsyncStoreImpl::createQueueHandle(const std::string& name,
+                                  const qpid::types::Variant::Map& opts)
 {
-    return qpid::broker::EnqueueHandle(new EnqueueHandleImpl(msgHandle, queueHandle));
+    return qpid::broker::QueueHandle(new QueueHandleImpl(name, opts));
+}
+
+qpid::broker::TxnHandle
+AsyncStoreImpl::createTxnHandle(const std::string& xid)
+{
+    return qpid::broker::TxnHandle(new TxnHandleImpl(xid));
 }
 
 void
 AsyncStoreImpl::submitPrepare(qpid::broker::TxnHandle& txnHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::TXN_PREPARE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::TXN_PREPARE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitCommit(qpid::broker::TxnHandle& txnHandle,
-                             qpid::broker::ResultCallback resultCb,
-                             qpid::broker::BrokerAsyncContext* brokerCtxt)
+                             boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::TXN_COMMIT,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::TXN_COMMIT,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitAbort(qpid::broker::TxnHandle& txnHandle,
-                            qpid::broker::ResultCallback resultCb,
-                            qpid::broker::BrokerAsyncContext* brokerCtxt)
+                            boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::TXN_ABORT,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::TXN_ABORT,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&txnHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitCreate(qpid::broker::ConfigHandle& cfgHandle,
-                             const qpid::broker::DataSource* dataSrc,
-                             qpid::broker::ResultCallback resultCb,
-                             qpid::broker::BrokerAsyncContext* brokerCtxt)
-{
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::CONFIG_CREATE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&cfgHandle),
-                                            dataSrc,
-                                            resultCb,
-                                            brokerCtxt);
+                             const qpid::broker::DataSource* const dataSrc,
+                             boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
+{
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::CONFIG_CREATE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&cfgHandle),
+                                                                  dataSrc,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitDestroy(qpid::broker::ConfigHandle& cfgHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::CONFIG_DESTROY,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&cfgHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::CONFIG_DESTROY,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&cfgHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitCreate(qpid::broker::QueueHandle& queueHandle,
-                             const qpid::broker::DataSource* dataSrc,
-                             qpid::broker::ResultCallback resultCb,
-                             qpid::broker::BrokerAsyncContext* brokerCtxt)
+                             const qpid::broker::DataSource* const dataSrc,
+                             boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::QUEUE_CREATE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&queueHandle),
-                                            dataSrc,
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::QUEUE_CREATE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&queueHandle),
+                                                                  dataSrc,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitDestroy(qpid::broker::QueueHandle& queueHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::QUEUE_DESTROY,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&queueHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::QUEUE_DESTROY,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&queueHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitFlush(qpid::broker::QueueHandle& queueHandle,
-                            qpid::broker::ResultCallback resultCb,
-                            qpid::broker::BrokerAsyncContext* brokerCtxt)
+                            boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::QUEUE_FLUSH,
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::QUEUE_FLUSH,
                                             dynamic_cast<qpid::broker::IdHandle*>(&queueHandle),
-                                            resultCb,
-                                            brokerCtxt);
+                                            brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitCreate(qpid::broker::EventHandle& eventHandle,
-                             const qpid::broker::DataSource* dataSrc,
-                             qpid::broker::ResultCallback resultCb,
-                             qpid::broker::BrokerAsyncContext* brokerCtxt)
-{
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::EVENT_CREATE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
-                                            dataSrc,
-                                            resultCb,
-                                            brokerCtxt);
+                             const qpid::broker::DataSource* const dataSrc,
+                             boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
+{
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::EVENT_CREATE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
+                                                                  dataSrc,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitCreate(qpid::broker::EventHandle& eventHandle,
-                             const qpid::broker::DataSource* dataSrc,
+                             const qpid::broker::DataSource* const dataSrc,
                              qpid::broker::TxnHandle& txnHandle,
-                             qpid::broker::ResultCallback resultCb,
-                             qpid::broker::BrokerAsyncContext* brokerCtxt)
+                             boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::EVENT_CREATE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
-                                            dataSrc,
-                                            &txnHandle,
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::EVENT_CREATE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
+                                                                  dataSrc,
+                                                                  &txnHandle,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitDestroy(qpid::broker::EventHandle& eventHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::EVENT_DESTROY,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::EVENT_DESTROY,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitDestroy(qpid::broker::EventHandle& eventHandle,
                               qpid::broker::TxnHandle& txnHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::EVENT_DESTROY,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
-                                            &txnHandle,
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::EVENT_DESTROY,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&eventHandle),
+                                                                  &txnHandle,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 
 void
 AsyncStoreImpl::submitEnqueue(qpid::broker::EnqueueHandle& enqHandle,
                               qpid::broker::TxnHandle& txnHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::MSG_ENQUEUE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&enqHandle),
-                                            &txnHandle,
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::MSG_ENQUEUE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&enqHandle),
+                                                                  &txnHandle,
+                                                                  brokerCtxt));
     m_operations.submit(op);
-//delete op;
-//delete brokerCtxt;
 }
 
 void
 AsyncStoreImpl::submitDequeue(qpid::broker::EnqueueHandle& enqHandle,
                               qpid::broker::TxnHandle& txnHandle,
-                              qpid::broker::ResultCallback resultCb,
-                              qpid::broker::BrokerAsyncContext* brokerCtxt)
+                              boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt)
 {
-    AsyncOperation* op = new AsyncOperation(AsyncOperation::MSG_DEQUEUE,
-                                            dynamic_cast<qpid::broker::IdHandle*>(&enqHandle),
-                                            &txnHandle,
-                                            resultCb,
-                                            brokerCtxt);
+    boost::shared_ptr<const AsyncOperation> op(new AsyncOperation(AsyncOperation::MSG_DEQUEUE,
+                                                                  dynamic_cast<qpid::broker::IdHandle*>(&enqHandle),
+                                                                  &txnHandle,
+                                                                  brokerCtxt));
     m_operations.submit(op);
 }
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/AsyncStoreImpl.h Fri Jun  8 14:59:04 2012
@@ -43,82 +43,71 @@ namespace asyncStore {
 class AsyncStoreImpl: public qpid::broker::AsyncStore {
 public:
     AsyncStoreImpl(boost::shared_ptr<qpid::sys::Poller> poller,
-                   const AsyncStoreOptions& opts,
-                   qpid::broker::AsyncResultQueue* resultQueue);
+                   const AsyncStoreOptions& opts);
     virtual ~AsyncStoreImpl();
     void initialize();
-    uint64_t getNextRid();
+    uint64_t getNextRid(); // Global counter for journal RIDs
 
-    // Management
+    // --- Management ---
 
     void initManagement(qpid::broker::Broker* broker);
 
-    // AsyncStore interface
+    // --- Factory methods for creating handles ---
+
 
-    qpid::broker::TxnHandle createTxnHandle(const std::string& xid=std::string());
     qpid::broker::ConfigHandle createConfigHandle();
-    qpid::broker::QueueHandle createQueueHandle(const std::string& name,
-                                                const qpid::types::Variant::Map& opts);
-    qpid::broker::EventHandle createEventHandle(qpid::broker::QueueHandle& queueHandle,
-                                                const std::string& key=std::string());
-    qpid::broker::MessageHandle createMessageHandle(const qpid::broker::DataSource* dataSrc);
     qpid::broker::EnqueueHandle createEnqueueHandle(qpid::broker::MessageHandle& msgHandle,
                                                     qpid::broker::QueueHandle& queueHandle);
+    qpid::broker::EventHandle createEventHandle(qpid::broker::QueueHandle& queueHandle,
+                                                const std::string& key=std::string());
+    qpid::broker::MessageHandle createMessageHandle(const qpid::broker::DataSource* const dataSrc);
+    qpid::broker::QueueHandle createQueueHandle(const std::string& name,
+                                                const qpid::types::Variant::Map& opts);
+    qpid::broker::TxnHandle createTxnHandle(const std::string& xid=std::string());
+
+
+    // --- Store async interface ---
 
     void submitPrepare(qpid::broker::TxnHandle& txnHandle,
-                       qpid::broker::ResultCallback resultCb,
-                       qpid::broker::BrokerAsyncContext* brokerCtxt);
+                       boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitCommit(qpid::broker::TxnHandle& txnHandle,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitAbort(qpid::broker::TxnHandle& txnHandle,
-                     qpid::broker::ResultCallback resultCb,
-                     qpid::broker::BrokerAsyncContext* brokerCtxt);
+                     boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
 
     void submitCreate(qpid::broker::ConfigHandle& cfgHandle,
-                      const qpid::broker::DataSource* dataSrc,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      const qpid::broker::DataSource* const dataSrc,
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitDestroy(qpid::broker::ConfigHandle& cfgHandle,
-                       qpid::broker::ResultCallback resultCb,
-                       qpid::broker::BrokerAsyncContext* brokerCtxt);
+                       boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
 
     void submitCreate(qpid::broker::QueueHandle& queueHandle,
-                      const qpid::broker::DataSource* dataSrc,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      const qpid::broker::DataSource* const dataSrc,
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitDestroy(qpid::broker::QueueHandle& queueHandle,
-                       qpid::broker::ResultCallback resultCb,
-                       qpid::broker::BrokerAsyncContext* brokerCtxt);
+                       boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitFlush(qpid::broker::QueueHandle& queueHandle,
-                     qpid::broker::ResultCallback resultCb,
-                     qpid::broker::BrokerAsyncContext* brokerCtxt);
+                     boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
 
     void submitCreate(qpid::broker::EventHandle& eventHandle,
-                      const qpid::broker::DataSource* dataSrc,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      const qpid::broker::DataSource* const dataSrc,
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitCreate(qpid::broker::EventHandle& eventHandle,
-                      const qpid::broker::DataSource* dataSrc,
+                      const qpid::broker::DataSource* const dataSrc,
                       qpid::broker::TxnHandle& txnHandle,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitDestroy(qpid::broker::EventHandle& eventHandle,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitDestroy(qpid::broker::EventHandle& eventHandle,
                       qpid::broker::TxnHandle& txnHandle,
-                      qpid::broker::ResultCallback resultCb,
-                      qpid::broker::BrokerAsyncContext* brokerCtxt);
+                      boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
 
     void submitEnqueue(qpid::broker::EnqueueHandle& enqHandle,
                        qpid::broker::TxnHandle& txnHandle,
-                       qpid::broker::ResultCallback resultCb,
-                       qpid::broker::BrokerAsyncContext* brokerCtxt);
+                       boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
     void submitDequeue(qpid::broker::EnqueueHandle& enqHandle,
                        qpid::broker::TxnHandle& txnHandle,
-                       qpid::broker::ResultCallback resultCb,
-                       qpid::broker::BrokerAsyncContext* brokerCtxt);
+                       boost::shared_ptr<qpid::broker::BrokerAsyncContext> brokerCtxt);
 
     // Legacy - Restore FTD message, is NOT async!
     virtual int loadContent(qpid::broker::MessageHandle& msgHandle,

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.cpp Fri Jun  8 14:59:04 2012
@@ -28,10 +28,8 @@
 namespace qpid {
 namespace asyncStore {
 
-OperationQueue::OperationQueue(const boost::shared_ptr<qpid::sys::Poller>& poller,
-                               qpid::broker::AsyncResultQueue* resultQueue) :
-        m_opQueue(boost::bind(&OperationQueue::handle, this, _1), poller),
-        m_resultQueue(resultQueue)
+OperationQueue::OperationQueue(const boost::shared_ptr<qpid::sys::Poller>& poller) :
+        m_opQueue(boost::bind(&OperationQueue::handle, this, _1), poller)
 {
     m_opQueue.start();
 }
@@ -42,9 +40,9 @@ OperationQueue::~OperationQueue()
 }
 
 void
-OperationQueue::submit(const AsyncOperation* op)
+OperationQueue::submit(boost::shared_ptr<const AsyncOperation> op)
 {
-std::cout << "--> OperationQueue::submit() op=" << op->getOpStr() << std::endl << std::flush;
+//std::cout << "--> OperationQueue::submit() op=" << op->getOpStr() << std::endl << std::flush;
     m_opQueue.push(op);
 }
 
@@ -53,19 +51,16 @@ OperationQueue::OpQueue::Batch::const_it
 OperationQueue::handle(const OperationQueue::OpQueue::Batch& e)
 {
     for (OpQueue::Batch::const_iterator i = e.begin(); i != e.end(); ++i) {
-std::cout << "<-- OperationQueue::handle() Op=" << (*i)->getOpStr() << std::endl << std::flush;
-        qpid::broker::BrokerAsyncContext* bc = (*i)->m_brokerCtxt;
-        qpid::broker::ResultCallback rcb = (*i)->m_resCb;
-        if (rcb) {
-//            ((*i)->m_resCb)(new qpid::broker::AsyncResult, (*i)->m_brokerCtxt);
-//            rcb(new qpid::broker::AsyncResultHandle(new qpid::broker::AsyncResultHandleImpl(bc)));
-            if (m_resultQueue) {
-                (m_resultQueue->*rcb)(new qpid::broker::AsyncResultHandle(new qpid::broker::AsyncResultHandleImpl(bc)));
+//std::cout << "<-- OperationQueue::handle() Op=" << (*i)->getOpStr() << std::endl << std::flush;
+        boost::shared_ptr<qpid::broker::BrokerAsyncContext> bc = (*i)->m_brokerCtxt;
+        if (bc) {
+            qpid::broker::AsyncResultQueue* const arq = bc->getAsyncResultQueue();
+            if (arq) {
+                qpid::broker::AsyncResultHandleImpl* arhi = new qpid::broker::AsyncResultHandleImpl(bc);
+                boost::shared_ptr<qpid::broker::AsyncResultHandle> arh(new qpid::broker::AsyncResultHandle(arhi));
+                arq->submit(arh);
             }
-        } else {
-            delete bc;
         }
-        delete (*i);
     }
     return e.end();
 }

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/OperationQueue.h Fri Jun  8 14:59:04 2012
@@ -35,15 +35,13 @@ namespace asyncStore {
 class OperationQueue
 {
 public:
-    OperationQueue(const boost::shared_ptr<qpid::sys::Poller>& poller,
-                   qpid::broker::AsyncResultQueue* resultQueue = 0);
+    OperationQueue(const boost::shared_ptr<qpid::sys::Poller>& poller);
     virtual ~OperationQueue();
-    void submit(const AsyncOperation* op);
+    void submit(boost::shared_ptr<const AsyncOperation> op);
 
 protected:
-    typedef qpid::sys::PollableQueue<const AsyncOperation*> OpQueue;
+    typedef qpid::sys::PollableQueue<boost::shared_ptr<const AsyncOperation> > OpQueue;
     OpQueue m_opQueue;
-    qpid::broker::AsyncResultQueue* m_resultQueue;
 
     OpQueue::Batch::const_iterator handle(const OpQueue::Batch& e);
 };

Modified: qpid/branches/asyncstore/cpp/src/qpid/asyncStore/Plugin.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/asyncStore/Plugin.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/asyncStore/Plugin.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/asyncStore/Plugin.cpp Fri Jun  8 14:59:04 2012
@@ -41,7 +41,7 @@ Plugin::earlyInitialize(Target& target)
 
         m_options.m_storeDir = dataDir.getPath ();
     }
-    m_store.reset(new qpid::asyncStore::AsyncStoreImpl(broker->getPoller(), m_options, 0)); // TODO: last arg: point to broker instance of AsyncResultQueue
+    m_store.reset(new qpid::asyncStore::AsyncStoreImpl(broker->getPoller(), m_options));
     boost::shared_ptr<qpid::broker::AsyncStore> brokerAsyncStore(m_store);
     broker->setAsyncStore(brokerAsyncStore);
     boost::function<void()> fn = boost::bind(&Plugin::finalize, this);

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.cpp Fri Jun  8 14:59:04 2012
@@ -65,10 +65,16 @@ AsyncResultHandle::getErrMsg() const
     return impl->getErrMsg();
 }
 
-const BrokerAsyncContext*
+boost::shared_ptr<BrokerAsyncContext>
 AsyncResultHandle::getBrokerAsyncContext() const
 {
     return impl->getBrokerAsyncContext();
 }
 
+void
+AsyncResultHandle::invokeAsyncResultCallback() const
+{
+    impl->getBrokerAsyncContext()->invokeCallback(this);
+}
+
 }} // namespace qpid::broker

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandle.h Fri Jun  8 14:59:04 2012
@@ -43,11 +43,10 @@ public:
 
     int getErrNo() const;
     std::string getErrMsg() const;
-    const BrokerAsyncContext* getBrokerAsyncContext() const;
+    boost::shared_ptr<BrokerAsyncContext> getBrokerAsyncContext() const;
+    void invokeAsyncResultCallback() const;
 
 private:
-    typedef qpid::broker::AsyncResultHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<AsyncResultHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.cpp Fri Jun  8 14:59:04 2012
@@ -28,17 +28,18 @@ namespace broker {
 
 AsyncResultHandleImpl::AsyncResultHandleImpl() :
         m_errNo(0),
-        m_errMsg(),
-        m_bc(0)
+        m_errMsg()
 {}
 
-AsyncResultHandleImpl::AsyncResultHandleImpl(const BrokerAsyncContext* bc) :
+AsyncResultHandleImpl::AsyncResultHandleImpl(boost::shared_ptr<BrokerAsyncContext> bc) :
         m_errNo(0),
         m_errMsg(),
         m_bc(bc)
 {}
 
-AsyncResultHandleImpl::AsyncResultHandleImpl(const int errNo, const std::string& errMsg, const BrokerAsyncContext* bc) :
+AsyncResultHandleImpl::AsyncResultHandleImpl(const int errNo,
+                                             const std::string& errMsg,
+                                             boost::shared_ptr<BrokerAsyncContext> bc) :
         m_errNo(errNo),
         m_errMsg(errMsg),
         m_bc(bc)
@@ -59,7 +60,7 @@ AsyncResultHandleImpl::getErrMsg() const
     return m_errMsg;
 }
 
-const BrokerAsyncContext*
+boost::shared_ptr<BrokerAsyncContext>
 AsyncResultHandleImpl::getBrokerAsyncContext() const
 {
     return m_bc;

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultHandleImpl.h Fri Jun  8 14:59:04 2012
@@ -35,18 +35,20 @@ class AsyncResultHandleImpl : public vir
 {
 public:
     AsyncResultHandleImpl();
-    AsyncResultHandleImpl(const BrokerAsyncContext* bc);
-    AsyncResultHandleImpl(const int errNo, const std::string& errMsg, const BrokerAsyncContext* bc);
+    AsyncResultHandleImpl(boost::shared_ptr<BrokerAsyncContext> bc);
+    AsyncResultHandleImpl(const int errNo,
+                          const std::string& errMsg,
+                          boost::shared_ptr<BrokerAsyncContext> bc);
     virtual ~AsyncResultHandleImpl();
 
     int getErrNo() const;
     std::string getErrMsg() const;
-    const BrokerAsyncContext* getBrokerAsyncContext() const;
+    boost::shared_ptr<BrokerAsyncContext> getBrokerAsyncContext() const;
 
 private:
     const int m_errNo;
     const std::string m_errMsg;
-    const BrokerAsyncContext* m_bc;
+    boost::shared_ptr<BrokerAsyncContext> m_bc;
 };
 
 }} // namespace qpid::broker

Copied: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.cpp (from r1347588, qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.cpp)
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.cpp?p2=qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.cpp&p1=qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.cpp&r1=1347588&r2=1348098&rev=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.cpp Fri Jun  8 14:59:04 2012
@@ -18,44 +18,44 @@
  */
 
 /**
- * \file AsyncResultQueue.cpp
+ * \file AsyncResultQueueImpl.cpp
  */
 
-#include "AsyncResultQueue.h"
+#include "AsyncResultHandle.h"
+#include "AsyncResultQueueImpl.h"
 
 namespace qpid {
 namespace broker {
 
-AsyncResultQueue::AsyncResultQueue(const boost::shared_ptr<qpid::sys::Poller>& poller) :
-        m_resQueue(boost::bind(&AsyncResultQueue::handle, this, _1), poller)
+AsyncResultQueueImpl::AsyncResultQueueImpl(const boost::shared_ptr<qpid::sys::Poller>& poller) :
+        m_resQueue(boost::bind(&AsyncResultQueueImpl::handle, this, _1), poller)
 {
     m_resQueue.start();
 }
 
-AsyncResultQueue::~AsyncResultQueue()
+AsyncResultQueueImpl::~AsyncResultQueueImpl()
 {
     m_resQueue.stop();
 }
 
 void
-AsyncResultQueue::submit(AsyncResultHandle* res)
+AsyncResultQueueImpl::submit(boost::shared_ptr<AsyncResultHandle> arh)
 {
-    m_resQueue.push(res);
+//std::cout << "==> AsyncResultQueueImpl::submit() errNo=" << arh->getErrNo() << " errMsg=\"" << arh->getErrMsg() << "\"" << std::endl << std::flush;
+    m_resQueue.push(arh);
 }
 
-//static
-/*
-void
-AsyncResultQueue::submit(AsyncResultQueue* arq, AsyncResultHandle* rh)
-{
-    arq->submit(rh);
-}
-*/
-
 // protected
-AsyncResultQueue::ResultQueue::Batch::const_iterator
-AsyncResultQueue::handle(const ResultQueue::Batch& e)
+AsyncResultQueueImpl::ResultQueue::Batch::const_iterator
+AsyncResultQueueImpl::handle(const ResultQueue::Batch& e)
 {
+
+    for (ResultQueue::Batch::const_iterator i = e.begin(); i != e.end(); ++i) {
+//std::cout << "<== AsyncResultQueueImpl::handle() errNo=" << (*i)->getErrNo() << " errMsg=\"" << (*i)->getErrMsg() << "\"" << std::endl << std::flush;
+        if ((*i)->isValid()) {
+            (*i)->invokeAsyncResultCallback();
+        }
+    }
     return e.end();
 }
 

Copied: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.h (from r1347588, qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.h)
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.h?p2=qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.h&p1=qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.h&r1=1347588&r2=1348098&rev=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueue.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncResultQueueImpl.h Fri Jun  8 14:59:04 2012
@@ -18,11 +18,13 @@
  */
 
 /**
- * \file AsyncResultQueue.h
+ * \file AsyncResultQueueImpl.h
  */
 
-#ifndef qpid_broker_AsyncResultQueue_h_
-#define qpid_broker_AsyncResultQueue_h_
+#ifndef qpid_broker_AsyncResultQueueImpl_h_
+#define qpid_broker_AsyncResultQueueImpl_h_
+
+#include "AsyncStore.h"
 
 #include "qpid/sys/PollableQueue.h"
 
@@ -31,16 +33,15 @@ namespace broker {
 
 class AsyncResultHandle;
 
-class AsyncResultQueue
+class AsyncResultQueueImpl : public AsyncResultQueue
 {
 public:
-    AsyncResultQueue(const boost::shared_ptr<qpid::sys::Poller>& poller);
-    virtual ~AsyncResultQueue();
-    void submit(AsyncResultHandle* rh);
-//    static void submit(AsyncResultQueue* arq, AsyncResultHandle* rh);
+    AsyncResultQueueImpl(const boost::shared_ptr<qpid::sys::Poller>& poller);
+    virtual ~AsyncResultQueueImpl();
+    virtual void submit(boost::shared_ptr<AsyncResultHandle> arh);
 
 protected:
-    typedef qpid::sys::PollableQueue<const AsyncResultHandle*> ResultQueue;
+    typedef qpid::sys::PollableQueue<boost::shared_ptr<const AsyncResultHandle> > ResultQueue;
     ResultQueue m_resQueue;
 
     ResultQueue::Batch::const_iterator handle(const ResultQueue::Batch& e);
@@ -48,4 +49,4 @@ protected:
 
 }} // namespace qpid::broker
 
-#endif // qpid_broker_AsyncResultQueue_h_
+#endif // qpid_broker_AsyncResultQueueImpl_h_

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.cpp Fri Jun  8 14:59:04 2012
@@ -22,35 +22,16 @@
 namespace qpid {
 namespace broker {
 
-BrokerAsyncContext::~BrokerAsyncContext()
+AsyncResultQueue::~AsyncResultQueue()
 {}
 
-DataSource::~DataSource()
+BrokerAsyncContext::~BrokerAsyncContext()
 {}
 
-AsyncStore::AsyncStore()
+DataSource::~DataSource()
 {}
 
 AsyncStore::~AsyncStore()
 {}
 
-/*
-AsyncResult::AsyncResult() :
-        errNo(0),
-        errMsg()
-{}
-
-AsyncResult::AsyncResult(const int errNo,
-                         const std::string& errMsg) :
-        errNo(errNo),
-        errMsg(errMsg)
-{}
-
-void
-AsyncResult::destroy()
-{
-    delete this;
-}
-*/
-
 }} // namespace qpid::broker

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/AsyncStore.h Fri Jun  8 14:59:04 2012
@@ -24,48 +24,31 @@
 // does not allow it. Using a local map<std::string, Variant> definition also precludes forward declaration.
 #include "qpid/types/Variant.h" // qpid::types::Variant::Map
 
+#include <boost/shared_ptr.hpp>
 #include <stdint.h>
 #include <string>
 
 namespace qpid {
 namespace broker {
 
-// Defined by broker, implements qpid::messaging::Handle-type template to hide ref counting
-// Subclass this for specific contexts
-class BrokerAsyncContext {
-public:
-    virtual ~BrokerAsyncContext();
-};
-
-// Callback definition:
-//struct AsyncResult {
-//    int errNo; // 0 implies no error
-//    std::string errMsg;
-//    AsyncResult();
-//    AsyncResult(const int errNo,
-//                const std::string& errMsg);
-//    void destroy();
-//};
-//typedef void (*ResultCallback)(const AsyncResult*, BrokerAsyncContext*);
-
+// This handle carries async op results
 class AsyncResultHandle;
-class AsyncResultQueue; // Implements the result callback function
 
-// Singleton class in broker which contains return pollable queue. Use submitAsyncResult() to add reulsts to queue.
-class AsyncResultHandler {
+// Broker to subclass as a pollable queue
+class AsyncResultQueue {
 public:
-    virtual ~AsyncResultHandler();
-
-    // Factory method to create result handle
-
-    virtual AsyncResultHandle createAsyncResultHandle(const int errNo, const std::string& errMsg, BrokerAsyncContext*) = 0;
-
-    // Async return interface
+    virtual ~AsyncResultQueue();
+    // TODO: Remove boost::shared_ptr<> from this interface
+    virtual void submit(boost::shared_ptr<AsyncResultHandle>) = 0;
+};
 
-    virtual void submitAsyncResult(AsyncResultHandle&) = 0;
+// Subclass this for specific contexts
+class BrokerAsyncContext {
+public:
+    virtual ~BrokerAsyncContext();
+    virtual AsyncResultQueue* getAsyncResultQueue() const = 0;
+    virtual void invokeCallback(const AsyncResultHandle* const) const = 0;
 };
-typedef void (qpid::broker::AsyncResultQueue::*ResultCallback)(AsyncResultHandle*);
-//typedef void (qpid::broker::AsyncResultQueue::*ResultCallback)(AsyncResultQueue*, AsyncResultHandle*);
 
 class DataSource {
 public:
@@ -74,6 +57,9 @@ public:
     virtual void write(char* target) = 0;
 };
 
+// Callback invoked by AsyncResultQueue to pass back async results
+typedef void (*AsyncResultCallback)(const AsyncResultHandle* const);
+
 class ConfigHandle;
 class EnqueueHandle;
 class EventHandle;
@@ -85,39 +71,39 @@ class TxnHandle;
 // Subclassed by store:
 class AsyncStore {
 public:
-    AsyncStore();
     virtual ~AsyncStore();
 
-    // Factory methods for creating handles
+    // --- Factory methods for creating handles ---
 
     virtual ConfigHandle createConfigHandle() = 0;
     virtual EnqueueHandle createEnqueueHandle(MessageHandle&, QueueHandle&) = 0;
     virtual EventHandle createEventHandle(QueueHandle&, const std::string& key=std::string()) = 0;
-    virtual MessageHandle createMessageHandle(const DataSource*) = 0;
+    virtual MessageHandle createMessageHandle(const DataSource* const) = 0;
     virtual QueueHandle createQueueHandle(const std::string& name, const qpid::types::Variant::Map& opts) = 0;
-    virtual TxnHandle createTxnHandle(const std::string& xid=std::string()) = 0;
+    virtual TxnHandle createTxnHandle(const std::string& xid=std::string()) = 0; // Distr. txns must supply xid
 
 
-    // Store async interface
+    // --- Store async interface ---
 
-    virtual void submitPrepare(TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0; // Distributed txns only
-    virtual void submitCommit(TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitAbort(TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
+    // TODO: Remove boost::shared_ptr<> from this interface
+    virtual void submitPrepare(TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0; // Distributed txns only
+    virtual void submitCommit(TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitAbort(TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
 
-    virtual void submitCreate(ConfigHandle&, const DataSource*, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitDestroy(ConfigHandle&, ResultCallback, BrokerAsyncContext*) = 0;
+    virtual void submitCreate(ConfigHandle&, const DataSource* const, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitDestroy(ConfigHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
 
-    virtual void submitCreate(QueueHandle&, const DataSource*, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitDestroy(QueueHandle&, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitFlush(QueueHandle&, ResultCallback, BrokerAsyncContext*) = 0;
+    virtual void submitCreate(QueueHandle&, const DataSource* const, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitDestroy(QueueHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitFlush(QueueHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
 
-    virtual void submitCreate(EventHandle&, const DataSource*, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitCreate(EventHandle&, const DataSource*, TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitDestroy(EventHandle&, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitDestroy(EventHandle&, TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
+    virtual void submitCreate(EventHandle&, const DataSource* const, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitCreate(EventHandle&, const DataSource* const, TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitDestroy(EventHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitDestroy(EventHandle&, TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
 
-    virtual void submitEnqueue(EnqueueHandle&, TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
-    virtual void submitDequeue(EnqueueHandle&, TxnHandle&, ResultCallback, BrokerAsyncContext*) = 0;
+    virtual void submitEnqueue(EnqueueHandle&, TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
+    virtual void submitDequeue(EnqueueHandle&, TxnHandle&, boost::shared_ptr<BrokerAsyncContext>) = 0;
 
     // Legacy - Restore FTD message, is NOT async!
     virtual int loadContent(MessageHandle&, QueueHandle&, char* data, uint64_t offset, const uint64_t length) = 0;

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/ConfigHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/ConfigHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/ConfigHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/ConfigHandle.h Fri Jun  8 14:59:04 2012
@@ -44,8 +44,6 @@ public:
     // <none>
 
 private:
-    typedef qpid::asyncStore::ConfigHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<ConfigHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/EnqueueHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/EnqueueHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/EnqueueHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/EnqueueHandle.h Fri Jun  8 14:59:04 2012
@@ -44,8 +44,6 @@ public:
     // <none>
 
 private:
-    typedef qpid::asyncStore::EnqueueHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<EnqueueHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/EventHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/EventHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/EventHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/EventHandle.h Fri Jun  8 14:59:04 2012
@@ -44,8 +44,6 @@ public:
     const std::string& getKey() const;
 
 private:
-    typedef qpid::asyncStore::EventHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<EventHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/MessageHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/MessageHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/MessageHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/MessageHandle.h Fri Jun  8 14:59:04 2012
@@ -45,8 +45,6 @@ public:
     // <none>
 
 private:
-    //typedef qpid::asyncStore::MessageHandleImpl Impl;
-    //Impl* impl;
     friend class qpid::messaging::PrivateImplRef<MessageHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/QueueHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/QueueHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/QueueHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/QueueHandle.h Fri Jun  8 14:59:04 2012
@@ -44,8 +44,6 @@ public:
     const std::string& getName() const;
 
 private:
-    typedef qpid::asyncStore::QueueHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<QueueHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/qpid/broker/TxnHandle.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/qpid/broker/TxnHandle.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/qpid/broker/TxnHandle.h (original)
+++ qpid/branches/asyncstore/cpp/src/qpid/broker/TxnHandle.h Fri Jun  8 14:59:04 2012
@@ -45,8 +45,6 @@ public:
     bool is2pc() const;
 
 private:
-    typedef qpid::asyncStore::TxnHandleImpl Impl;
-    Impl* impl;
     friend class qpid::messaging::PrivateImplRef<TxnHandle>;
 };
 

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MessageConsumer.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MessageConsumer.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MessageConsumer.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MessageConsumer.cpp Fri Jun  8 14:59:04 2012
@@ -46,6 +46,7 @@ MessageConsumer::~MessageConsumer()
 void*
 MessageConsumer::runConsumers()
 {
+/*
     uint32_t numMsgs = 0;
     while (numMsgs < m_perfTestParams.m_numMsgs) {
         if (m_queue->dispatch()) {
@@ -54,6 +55,7 @@ MessageConsumer::runConsumers()
             ::usleep(1000); // TODO - replace this poller with condition variable
         }
     }
+*/
     return 0;
 }
 

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.cpp Fri Jun  8 14:59:04 2012
@@ -30,7 +30,7 @@
 #include "QueuedMessage.h"
 
 #include "qpid/asyncStore/AsyncStoreImpl.h"
-#include "qpid/broker/AsyncResultQueue.h"
+#include "qpid/broker/AsyncResultHandle.h"
 
 namespace tests {
 namespace storePerftools {
@@ -39,11 +39,11 @@ namespace asyncPerf {
 MockPersistableQueue::MockPersistableQueue(const std::string& name,
                                            const qpid::framing::FieldTable& /*args*/,
                                            qpid::asyncStore::AsyncStoreImpl* store,
-                                           qpid::broker::AsyncResultQueue& resultQueue) :
+                                           qpid::broker::AsyncResultQueue& arq) :
         qpid::broker::PersistableQueue(),
         m_name(name),
         m_store(store),
-        m_resultQueue(resultQueue),
+        m_resultQueue(arq),
         m_asyncOpCounter(0UL),
         m_persistenceId(0ULL),
         m_persistableData(m_name), // TODO: Currently queue durable data consists only of the queue name. Update this.
@@ -67,18 +67,17 @@ MockPersistableQueue::~MockPersistableQu
 }
 
 // static
-/*
 void
-MockPersistableQueue::handleAsyncResult(const qpid::broker::AsyncResult* res,
-                                        qpid::broker::BrokerAsyncContext* bc)
+MockPersistableQueue::handleAsyncResult(const qpid::broker::AsyncResultHandle* const arh)
 {
-    if (bc && res) {
-        QueueAsyncContext* qc = dynamic_cast<QueueAsyncContext*>(bc);
-        if (res->errNo) {
+    if (arh) {
+        boost::shared_ptr<QueueAsyncContext> qc = boost::dynamic_pointer_cast<QueueAsyncContext>(arh->getBrokerAsyncContext());
+        if (arh->getErrNo()) {
             // TODO: Handle async failure here (other than by simply printing a message)
             std::cerr << "Queue name=\"" << qc->getQueue()->m_name << "\": Operation " << qc->getOpStr() << ": failure "
-                      << res->errNo << " (" << res->errMsg << ")" << std::endl;
+                      << arh->getErrNo() << " (" << arh->getErrMsg() << ")" << std::endl;
         } else {
+//std::cout << "QQQ MockPersistableQueue::handleAsyncResult() op=" << qc->getOpStr() << std::endl << std::flush;
             // Handle async success here
             switch(qc->getOpCode()) {
             case qpid::asyncStore::AsyncOperation::QUEUE_CREATE:
@@ -103,10 +102,7 @@ MockPersistableQueue::handleAsyncResult(
             };
         }
     }
-    if (bc) delete bc;
-    if (res) delete res;
 }
-*/
 
 const qpid::broker::QueueHandle&
 MockPersistableQueue::getHandle() const
@@ -129,14 +125,14 @@ MockPersistableQueue::getStore()
 void
 MockPersistableQueue::asyncCreate()
 {
-    qpid::broker::ResultCallback rcb = &qpid::broker::AsyncResultQueue::submit;
     if (m_store) {
+        boost::shared_ptr<QueueAsyncContext> qac(new QueueAsyncContext(shared_from_this(),
+                                                                       qpid::asyncStore::AsyncOperation::QUEUE_CREATE,
+                                                                       &handleAsyncResult,
+                                                                       &m_resultQueue));
         m_store->submitCreate(m_queueHandle,
                               this,
-                              rcb,
-//                              &qpid::broker::AsyncResultQueue::submit/*&m_resultQueue.submit*/,
-                              new QueueAsyncContext(shared_from_this(),
-                                                    qpid::asyncStore::AsyncOperation::QUEUE_CREATE));
+                              qac);
         ++m_asyncOpCounter;
     }
 }
@@ -147,10 +143,12 @@ MockPersistableQueue::asyncDestroy(const
     m_destroyPending = true;
     if (m_store) {
         if (deleteQueue) {
+            boost::shared_ptr<QueueAsyncContext> qac(new QueueAsyncContext(shared_from_this(),
+                                                                           qpid::asyncStore::AsyncOperation::QUEUE_DESTROY,
+                                                                           &handleAsyncResult,
+                                                                           &m_resultQueue));
             m_store->submitDestroy(m_queueHandle,
-                                   &qpid::broker::AsyncResultQueue::submit/*&m_resultQueue.submit*/,
-                                   new QueueAsyncContext(shared_from_this(),
-                                                         qpid::asyncStore::AsyncOperation::QUEUE_DESTROY));
+                                   qac);
             ++m_asyncOpCounter;
         }
         m_asyncOpCounter.waitForZero(qpid::sys::Duration(10UL*1000*1000*1000));
@@ -162,6 +160,7 @@ MockPersistableQueue::deliver(boost::sha
 {
     QueuedMessage qm(this, msg);
     if(enqueue((MockTransactionContext*)0, qm)) {
+        // TODO: Do we need to wait for the enqueue to complete before push()ing the msg?
         push(qm);
     }
 }
@@ -334,12 +333,14 @@ MockPersistableQueue::asyncEnqueue(MockT
 {
     qm.payload()->setPersistenceId(m_store->getNextRid());
 //std::cout << "QQQ Queue=\"" << m_name << "\": asyncEnqueue() rid=0x" << std::hex << qm.payload()->getPersistenceId() << std::dec << std::endl << std::flush;
-    m_store->submitEnqueue(/*enqHandle*/qm.enqHandle(),
+    boost::shared_ptr<QueueAsyncContext> qac(new QueueAsyncContext(shared_from_this(),
+                                                                   qm.payload(),
+                                                                   qpid::asyncStore::AsyncOperation::MSG_ENQUEUE,
+                                                                   &handleAsyncResult,
+                                                                   &m_resultQueue));
+    m_store->submitEnqueue(qm.enqHandle(),
                            txn->getHandle(),
-                           &qpid::broker::AsyncResultQueue::submit/*&m_resultQueue.submit*/,
-                           new QueueAsyncContext(shared_from_this(),
-                                                 qm.payload(),
-                                                 qpid::asyncStore::AsyncOperation::MSG_ENQUEUE));
+                           qac);
     ++m_asyncOpCounter;
     return true;
 }
@@ -350,13 +351,14 @@ MockPersistableQueue::asyncDequeue(MockT
                                    QueuedMessage& qm)
 {
 //std::cout << "QQQ Queue=\"" << m_name << "\": asyncDequeue() rid=0x" << std::hex << qm.payload()->getPersistenceId() << std::dec << std::endl << std::flush;
-    qpid::broker::EnqueueHandle enqHandle = qm.enqHandle();
-    m_store->submitDequeue(enqHandle,
+    boost::shared_ptr<QueueAsyncContext> qac(new QueueAsyncContext(shared_from_this(),
+                                                                   qm.payload(),
+                                                                   qpid::asyncStore::AsyncOperation::MSG_DEQUEUE,
+                                                                   &handleAsyncResult,
+                                                                   &m_resultQueue));
+    m_store->submitDequeue(qm.enqHandle(),
                            txn->getHandle(),
-                           &qpid::broker::AsyncResultQueue::submit/*&m_resultQueue.submit*/,
-                           new QueueAsyncContext(shared_from_this(),
-                                                 qm.payload(),
-                                                 qpid::asyncStore::AsyncOperation::MSG_DEQUEUE));
+                           qac);
     ++m_asyncOpCounter;
     return true;
 }
@@ -374,7 +376,7 @@ MockPersistableQueue::destroyCheck(const
 
 // protected
 void
-MockPersistableQueue::createComplete(const QueueAsyncContext* qc)
+MockPersistableQueue::createComplete(const boost::shared_ptr<QueueAsyncContext> qc)
 {
 //std::cout << "QQQ Queue name=\"" << qc->getQueue()->getName() << "\": createComplete()" << std::endl << std::flush;
     assert(qc->getQueue().get() == this);
@@ -383,7 +385,7 @@ MockPersistableQueue::createComplete(con
 
 // protected
 void
-MockPersistableQueue::flushComplete(const QueueAsyncContext* qc)
+MockPersistableQueue::flushComplete(const boost::shared_ptr<QueueAsyncContext> qc)
 {
 //std::cout << "QQQ Queue name=\"" << qc->getQueue()->getName() << "\": flushComplete()" << std::endl << std::flush;
     assert(qc->getQueue().get() == this);
@@ -392,7 +394,7 @@ MockPersistableQueue::flushComplete(cons
 
 // protected
 void
-MockPersistableQueue::destroyComplete(const QueueAsyncContext* qc)
+MockPersistableQueue::destroyComplete(const boost::shared_ptr<QueueAsyncContext> qc)
 {
 //std::cout << "QQQ Queue name=\"" << qc->getQueue()->getName() << "\": destroyComplete()" << std::endl << std::flush;
     assert(qc->getQueue().get() == this);
@@ -401,7 +403,7 @@ MockPersistableQueue::destroyComplete(co
 }
 
 void
-MockPersistableQueue::enqueueComplete(const QueueAsyncContext* qc)
+MockPersistableQueue::enqueueComplete(const boost::shared_ptr<QueueAsyncContext> qc)
 {
 //std::cout << "QQQ Queue name=\"" << qc->getQueue()->getName() << "\": enqueueComplete() rid=0x" << std::hex << qc->getMessage()->getPersistenceId() << std::dec << std::endl << std::flush;
     assert(qc->getQueue().get() == this);
@@ -409,7 +411,7 @@ MockPersistableQueue::enqueueComplete(co
 }
 
 void
-MockPersistableQueue::dequeueComplete(const QueueAsyncContext* qc)
+MockPersistableQueue::dequeueComplete(const boost::shared_ptr<QueueAsyncContext> qc)
 {
 //std::cout << "QQQ Queue name=\"" << qc->getQueue()->getName() << "\": dequeueComplete() rid=0x" << std::hex << qc->getMessage()->getPersistenceId() << std::dec << std::endl << std::flush;
     assert(qc->getQueue().get() == this);

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.h (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/MockPersistableQueue.h Fri Jun  8 14:59:04 2012
@@ -64,11 +64,10 @@ public:
     MockPersistableQueue(const std::string& name,
                          const qpid::framing::FieldTable& args,
                          qpid::asyncStore::AsyncStoreImpl* store,
-                         qpid::broker::AsyncResultQueue& rq);
+                         qpid::broker::AsyncResultQueue& arq);
     virtual ~MockPersistableQueue();
 
-//    static void handleAsyncResult(const qpid::broker::AsyncResult* res,
-//                                  qpid::broker::BrokerAsyncContext* bc);
+    static void handleAsyncResult(const qpid::broker::AsyncResultHandle* const res);
     const qpid::broker::QueueHandle& getHandle() const;
     qpid::broker::QueueHandle& getHandle();
     qpid::asyncStore::AsyncStoreImpl* getStore();
@@ -143,11 +142,11 @@ protected:
     void destroyCheck(const std::string& opDescr) const;
 
     // --- Async op completions (called through handleAsyncResult) ---
-    void createComplete(const QueueAsyncContext* qc);
-    void flushComplete(const QueueAsyncContext* qc);
-    void destroyComplete(const QueueAsyncContext* qc);
-    void enqueueComplete(const QueueAsyncContext* qc);
-    void dequeueComplete(const QueueAsyncContext* qc);
+    void createComplete(const boost::shared_ptr<QueueAsyncContext> qc);
+    void flushComplete(const boost::shared_ptr<QueueAsyncContext> qc);
+    void destroyComplete(const boost::shared_ptr<QueueAsyncContext> qc);
+    void enqueueComplete(const boost::shared_ptr<QueueAsyncContext> qc);
+    void dequeueComplete(const boost::shared_ptr<QueueAsyncContext> qc);
 };
 
 }}} // namespace tests::storePerftools::asyncPerf

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.cpp Fri Jun  8 14:59:04 2012
@@ -32,7 +32,6 @@
 #include "tests/storePerftools/common/Thread.h"
 
 #include "qpid/asyncStore/AsyncStoreImpl.h"
-#include "qpid/broker/AsyncResultQueue.h"
 #include "qpid/sys/Poller.h"
 
 #include <iomanip>
@@ -70,7 +69,7 @@ PerfTest::~PerfTest()
 void
 PerfTest::prepareStore()
 {
-    m_store = new qpid::asyncStore::AsyncStoreImpl(m_poller, m_storeOpts, &m_resultQueue);
+    m_store = new qpid::asyncStore::AsyncStoreImpl(m_poller, m_storeOpts);
     m_store->initialize();
 }
 

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.h (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/PerfTest.h Fri Jun  8 14:59:04 2012
@@ -28,7 +28,7 @@
 
 #include "tests/storePerftools/common/Streamable.h"
 
-#include "qpid/broker/AsyncResultQueue.h"
+#include "qpid/broker/AsyncResultQueueImpl.h"
 #include "qpid/framing/FieldTable.h"
 #include "qpid/sys/Thread.h"
 
@@ -70,7 +70,7 @@ protected:
     const char* m_msgData;
     boost::shared_ptr<qpid::sys::Poller> m_poller;
     qpid::sys::Thread m_pollingThread;
-    qpid::broker::AsyncResultQueue m_resultQueue;
+    qpid::broker::AsyncResultQueueImpl m_resultQueue;
     qpid::asyncStore::AsyncStoreImpl* m_store;
     std::deque<boost::shared_ptr<MockPersistableQueue> > m_queueList;
     std::deque<boost::shared_ptr<MessageProducer> > m_producers;

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.cpp?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.cpp (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.cpp Fri Jun  8 14:59:04 2012
@@ -30,19 +30,27 @@ namespace storePerftools {
 namespace asyncPerf {
 
 QueueAsyncContext::QueueAsyncContext(boost::shared_ptr<MockPersistableQueue> q,
-                                     const qpid::asyncStore::AsyncOperation::opCode op) :
+                                     const qpid::asyncStore::AsyncOperation::opCode op,
+                                     qpid::broker::AsyncResultCallback rcb,
+                                     qpid::broker::AsyncResultQueue* const arq) :
         m_q(q),
-        m_op(op)
+        m_op(op),
+        m_rcb(rcb),
+        m_arq(arq)
 {
     assert(m_q.get() != 0);
 }
 
 QueueAsyncContext::QueueAsyncContext(boost::shared_ptr<MockPersistableQueue> q,
                                      boost::shared_ptr<MockPersistableMessage> msg,
-                                     const qpid::asyncStore::AsyncOperation::opCode op) :
+                                     const qpid::asyncStore::AsyncOperation::opCode op,
+                                     qpid::broker::AsyncResultCallback rcb,
+                                     qpid::broker::AsyncResultQueue* const arq) :
         m_q(q),
         m_msg(msg),
-        m_op(op)
+        m_op(op),
+        m_rcb(rcb),
+        m_arq(arq)
 {
     assert(m_q.get() != 0);
     assert(m_msg.get() != 0);
@@ -75,6 +83,24 @@ QueueAsyncContext::getMessage() const
     return m_msg;
 }
 
+qpid::broker::AsyncResultQueue*
+QueueAsyncContext::getAsyncResultQueue() const
+{
+    return m_arq;
+}
+
+qpid::broker::AsyncResultCallback
+QueueAsyncContext::getAsyncResultCallback() const
+{
+    return m_rcb;
+}
+
+void
+QueueAsyncContext::invokeCallback(const qpid::broker::AsyncResultHandle* const arh) const
+{
+    m_rcb(arh);
+}
+
 void
 QueueAsyncContext::destroy()
 {

Modified: qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.h
URL: http://svn.apache.org/viewvc/qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.h?rev=1348098&r1=1348097&r2=1348098&view=diff
==============================================================================
--- qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.h (original)
+++ qpid/branches/asyncstore/cpp/src/tests/storePerftools/asyncPerf/QueueAsyncContext.h Fri Jun  8 14:59:04 2012
@@ -29,6 +29,8 @@
 
 #include <boost/shared_ptr.hpp>
 
+
+
 namespace tests {
 namespace storePerftools {
 namespace asyncPerf {
@@ -40,21 +42,30 @@ class QueueAsyncContext: public qpid::br
 {
 public:
     QueueAsyncContext(boost::shared_ptr<MockPersistableQueue> q,
-                      const qpid::asyncStore::AsyncOperation::opCode op);
+                      const qpid::asyncStore::AsyncOperation::opCode op,
+                      qpid::broker::AsyncResultCallback rcb,
+                      qpid::broker::AsyncResultQueue* const arq);
     QueueAsyncContext(boost::shared_ptr<MockPersistableQueue> q,
                       boost::shared_ptr<MockPersistableMessage> msg,
-                      const qpid::asyncStore::AsyncOperation::opCode op);
+                      const qpid::asyncStore::AsyncOperation::opCode op,
+                      qpid::broker::AsyncResultCallback rcb,
+                      qpid::broker::AsyncResultQueue* const arq);
     virtual ~QueueAsyncContext();
     qpid::asyncStore::AsyncOperation::opCode getOpCode() const;
     const char* getOpStr() const;
     boost::shared_ptr<MockPersistableQueue> getQueue() const;
     boost::shared_ptr<MockPersistableMessage> getMessage() const;
+    qpid::broker::AsyncResultQueue* getAsyncResultQueue() const;
+    qpid::broker::AsyncResultCallback getAsyncResultCallback() const;
+    void invokeCallback(const qpid::broker::AsyncResultHandle* const arh) const;
     void destroy();
 
 protected:
     boost::shared_ptr<MockPersistableQueue> m_q;
     boost::shared_ptr<MockPersistableMessage> m_msg;
     const qpid::asyncStore::AsyncOperation::opCode m_op;
+    qpid::broker::AsyncResultCallback m_rcb;
+    qpid::broker::AsyncResultQueue* const m_arq;
 };
 
 }}} // namespace tests::storePerftools::asyncPerf



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org