You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2023/07/17 09:21:21 UTC
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20203
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
IMPALA-12290: Prevent flakiness of test_cache_metrics
Metrics in test_cache_metrics can naturally fluctuate depending on the
content of the catalog and the upper threshold is tight, increased it a
bit to have more leeway.
Test:
- Ran the test case locally a few times
Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
---
M tests/custom_cluster/test_local_catalog.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/20203/1
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13563/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Jul 2023 09:45:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 00:22:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Jul 2023 16:31:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
IMPALA-12290: Prevent flakiness of test_cache_metrics
Metrics in test_cache_metrics can naturally fluctuate depending on the
content of the catalog and the upper threshold is tight, increased it a
bit to have more leeway.
Test:
- Ran the test case locally a few times
Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Reviewed-on: http://gerrit.cloudera.org:8080/20203
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_local_catalog.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 04:32:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12290: Prevent flakiness of test cache metrics
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20203 )
Change subject: IMPALA-12290: Prevent flakiness of test_cache_metrics
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9512/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc5a87bdf723939a1b73e1da68053d4224eb193
Gerrit-Change-Number: 20203
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 00:22:16 +0000
Gerrit-HasComments: No