You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/11 07:58:53 UTC
[GitHub] [airflow] vanka56 opened a new pull request #9226: Adding functionality to shuffle HMS connections that way the requests…
vanka56 opened a new pull request #9226:
URL: https://github.com/apache/airflow/pull/9226
Adding functionality to shuffle HMS connections that way the requests to hms servers are load balanced.
Existing logic picks the first connection out of all connections pertaining to a specific conn_id and uses it for for all requests that is sent via HiveMetastoreHook. This code change shuffles the connections and make sure same HMS connection / server is not used all the time HiveMetastoreHook is instantiated. This is done by shuffling the hms connections
---
Make sure to mark the boxes below before creating PR: [x]
- [ X] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey edited a comment on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
Acehaidrey edited a comment on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-645025857
Think we can close this ticket and just merge in https://github.com/apache/airflow/pull/9280
What do you think @ashb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9226: Adding functionality to shuffle HMS connections that way the requests…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-642480830
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-643501533
This one is I'm afraid a "won't fix", at least for 2.0 because of https://github.com/apache/airflow/issues/8608
If you re-target this to v1-10-stble we could include it in 1.10.11 though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-648868596
Closing in favour of #9280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vanka56 commented on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
vanka56 commented on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-642906878
Checked all the boxes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-645025857
Think we can close this ticket and just merge in https://github.com/apache/airflow/issues/8608
What do you think @ashb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey edited a comment on pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
Acehaidrey edited a comment on pull request #9226:
URL: https://github.com/apache/airflow/pull/9226#issuecomment-645025857
Think we can close this ticket and just merge in https://github.com/apache/airflow/pull/9226
What do you think @ashb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #9226: Adding functionality to shuffle HMS connections to facilitate load balancing
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #9226:
URL: https://github.com/apache/airflow/pull/9226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org