You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/23 07:03:14 UTC

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

zhangjidi2016 opened a new pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   #3173 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-917590793


   IMO, Could it be configured as optional? Otherwise, the sudden change of log directory is very confused for users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r779576654



##########
File path: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
##########
@@ -187,6 +187,8 @@
 
     private boolean autoDeleteUnusedStats = false;
 
+    private boolean isolateLogEnable = false;

Review comment:
       It would be better to add some comments to explain the meaning of this parameter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee merged pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
francisoliverlee merged pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885646569


   
   [![Coverage Status](https://coveralls.io/builds/42888572/badge)](https://coveralls.io/builds/42888572)
   
   Coverage increased (+0.2%) to 54.401% when pulling **fc5180e6b11a2c5abe7f1c181b65dac8eb032352 on zhangjidi2016:broker_log** into **ec985ee67354a55607c3b5fde2e110dfb1268fea on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r779962241



##########
File path: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
##########
@@ -187,6 +187,8 @@
 
     private boolean autoDeleteUnusedStats = false;
 
+    private boolean isolateLogEnable = false;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885646569


   
   [![Coverage Status](https://coveralls.io/builds/41626671/badge)](https://coveralls.io/builds/41626671)
   
   Coverage decreased (-0.03%) to 54.003% when pulling **47175d88c60738157ae57fa5b2fde2563180ca34 on zhangjidi2016:broker_log** into **9a9039e8dcc5659628b724f58981e30c377ab5c3 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r676110608



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -187,6 +187,7 @@ public static BrokerController createBrokerController(String[] args) {
             JoranConfigurator configurator = new JoranConfigurator();
             configurator.setContext(lc);
             lc.reset();
+            System.setProperty("brokerLogDir", brokerConfig.getBrokerName() + "_" + brokerConfig.getBrokerId());

Review comment:
       > i
   > 
   > > In dleger mode, The broker id changes when the leader change. so if we restart the leader you will see broker id change from zero to non-zero
   > 
   > I think brokerport can be used
   
   If brokers are deployed in Dledger mode, use dLegerSelfId instead of brokerId




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-891466145


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3174](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc5180e) into [develop](https://codecov.io/gh/apache/rocketmq/commit/1e982af79fd36fe31979b828509daa1bc109185f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e982af) will **increase** coverage by `1.31%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3174/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3174      +/-   ##
   =============================================
   + Coverage      47.84%   49.15%   +1.31%     
   + Complexity      4555     3672     -883     
   =============================================
     Files            552      312     -240     
     Lines          36642    29380    -7262     
     Branches        4848     4183     -665     
   =============================================
   - Hits           17530    14441    -3089     
   + Misses         16883    12972    -3911     
   + Partials        2229     1967     -262     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/rocketmq/broker/BrokerStartup.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyU3RhcnR1cC5qYXZh) | `5.47% <0.00%> (-0.20%)` | :arrow_down: |
   | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: |
   | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: |
   | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: |
   | [...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | `34.41% <0.00%> (-1.52%)` | :arrow_down: |
   | [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `39.74% <0.00%> (-1.22%)` | :arrow_down: |
   | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `40.23% <0.00%> (-0.79%)` | :arrow_down: |
   | [...ion/AbstractTransactionalMessageCheckListener.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vQWJzdHJhY3RUcmFuc2FjdGlvbmFsTWVzc2FnZUNoZWNrTGlzdGVuZXIuamF2YQ==) | `75.67% <0.00%> (-0.65%)` | :arrow_down: |
   | [...he/rocketmq/remoting/protocol/RemotingCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nQ29tbWFuZC5qYXZh) | `78.22% <0.00%> (-0.41%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `55.54% <0.00%> (-0.17%)` | :arrow_down: |
   | ... and [279 more](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e982af...fc5180e](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
panzhi33 commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r676012231



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -187,6 +187,7 @@ public static BrokerController createBrokerController(String[] args) {
             JoranConfigurator configurator = new JoranConfigurator();
             configurator.setContext(lc);
             lc.reset();
+            System.setProperty("brokerLogDir", brokerConfig.getBrokerName() + "_" + brokerConfig.getBrokerId());

Review comment:
       i 
   
   > In dleger mode, The broker id changes when the leader change. so if we restart the leader you will see broker id change from zero to non-zero
   
   I think brokerport can be used




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r716433837



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -187,6 +187,13 @@ public static BrokerController createBrokerController(String[] args) {
             JoranConfigurator configurator = new JoranConfigurator();
             configurator.setContext(lc);
             lc.reset();
+            System.setProperty("brokerLogDir", "");

Review comment:
       If it is set to "" here, will it be in the original directory by default?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-891466145


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3174](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (764cfba) into [develop](https://codecov.io/gh/apache/rocketmq/commit/1e982af79fd36fe31979b828509daa1bc109185f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e982af) will **increase** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3174/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3174      +/-   ##
   =============================================
   + Coverage      47.84%   47.87%   +0.03%     
   + Complexity      4555     4552       -3     
   =============================================
     Files            552      552              
     Lines          36642    36524     -118     
     Branches        4848     4819      -29     
   =============================================
   - Hits           17530    17485      -45     
   + Misses         16883    16819      -64     
   + Partials        2229     2220       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/rocketmq/broker/BrokerStartup.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyU3RhcnR1cC5qYXZh) | `5.55% <0.00%> (-0.12%)` | :arrow_down: |
   | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: |
   | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-8.96%)` | :arrow_down: |
   | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
   | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: |
   | [...ache/rocketmq/store/AllocateMappedFileService.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FsbG9jYXRlTWFwcGVkRmlsZVNlcnZpY2UuamF2YQ==) | `39.02% <0.00%> (-2.44%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `28.85% <0.00%> (-1.32%)` | :arrow_down: |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `58.13% <0.00%> (-0.94%)` | :arrow_down: |
   | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `40.23% <0.00%> (-0.79%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/rocketmq/pull/3174/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e982af...764cfba](https://codecov.io/gh/apache/rocketmq/pull/3174?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-926372655


   @RongtongJin @yuz10  can you review this pr again ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r716525312



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -187,6 +187,13 @@ public static BrokerController createBrokerController(String[] args) {
             JoranConfigurator configurator = new JoranConfigurator();
             configurator.setContext(lc);
             lc.reset();
+            System.setProperty("brokerLogDir", "");

Review comment:
       yes, if brokerLogDir is "", the logPath in logback_broker.xml  is default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yuz10 commented on a change in pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#discussion_r676006944



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -187,6 +187,7 @@ public static BrokerController createBrokerController(String[] args) {
             JoranConfigurator configurator = new JoranConfigurator();
             configurator.setContext(lc);
             lc.reset();
+            System.setProperty("brokerLogDir", brokerConfig.getBrokerName() + "_" + brokerConfig.getBrokerId());

Review comment:
       In dleger mode, The broker id changes when the leader change. so if we restart the leader you will see broker id change from zero to non-zero




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885646569


   
   [![Coverage Status](https://coveralls.io/builds/45436866/badge)](https://coveralls.io/builds/45436866)
   
   Coverage decreased (-1.4%) to 53.088% when pulling **3738214a355d937441ea3854bc8a80cd5b2b4e3c on zhangjidi2016:broker_log** into **143ac3185b84aed5bc714b353af340aa1e3df0e6 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885986972


   ![image](https://user-images.githubusercontent.com/18254437/126854662-f0e3267d-38e6-4066-a81f-b809916e941b.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885646569


   
   [![Coverage Status](https://coveralls.io/builds/41596522/badge)](https://coveralls.io/builds/41596522)
   
   Coverage decreased (-0.06%) to 53.967% when pulling **e0406b2aa42126cf7ff9067ae7bbd985652dfb82 on zhangjidi2016:broker_log** into **9a9039e8dcc5659628b724f58981e30c377ab5c3 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3174: [ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3174:
URL: https://github.com/apache/rocketmq/pull/3174#issuecomment-885646569


   
   [![Coverage Status](https://coveralls.io/builds/41849577/badge)](https://coveralls.io/builds/41849577)
   
   Coverage increased (+0.1%) to 54.139% when pulling **764cfba296f4894a7021a3bd8be222bc1ab59cdf on zhangjidi2016:broker_log** into **9a9039e8dcc5659628b724f58981e30c377ab5c3 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org