You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2006/09/25 10:35:58 UTC

svn commit: r449606 - /james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java

Author: bago
Date: Mon Sep 25 01:35:55 2006
New Revision: 449606

URL: http://svn.apache.org/viewvc?view=rev&rev=449606
Log:
Simplifications for the previous DNSService refactoring (JSPF-29)

Modified:
    james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java?view=diff&rev=449606&r1=449605&r2=449606
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/DNSServiceXBillImpl.java Mon Sep 25 01:35:55 2006
@@ -209,8 +209,6 @@
      * @see org.apache.james.jspf.core.DNSService#getPTRRecords(java.lang.String)
      */
     public List getPTRRecords(String ipAddress) throws PermErrorException, TempErrorException {
-        ArrayList ptrR = new ArrayList();
-
         // do DNS lookup for TXT
         IPAddr ip = IPAddr.getAddress(ipAddress);
 
@@ -219,13 +217,7 @@
         // check if the maximum lookup count is reached
         if (recordLimit > 0 && records.size() > recordLimit) throw new PermErrorException("Maximum PTR lookup count reached");
   
-        for (int i = 0; i < records.size(); i++) {
-            String ptr = (String) records.get(i);
-            ptrR.add(ptr);
-            log.debug("Add ipAddress " + ptr + " to list");
-        }
-
-        return ptrR;
+        return records;
     }
 
     /**
@@ -235,7 +227,7 @@
     public List getMXRecords(String domainName)
             throws PermErrorException, TempErrorException {
 
-        ArrayList mxR = null;
+        List mxR = null;
         List records = getRecords(domainName, MX);
 
         // check if the maximum lookup count is reached



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org