[GitHub] [pulsar-client-node] RobertIndie commented on a diff in pull request #313: [fix] Add tests for produce and consume with TLS enabled

["RobertIndie (via GitHub)" <gi...@apache.org>]

RobertIndie commented on code in PR #313:
URL: https://github.com/apache/pulsar-client-node/pull/313#discussion_r1159367887


##########
build-support/pulsar-test-container-start.sh:
##########
@@ -30,6 +30,13 @@ bin/pulsar-daemon start standalone \
         --bookkeeper-dir data/bookkeeper
 
 echo "-- Wait for Pulsar service to be ready"
-until curl http://localhost:8080/metrics > /dev/null 2>&1 ; do sleep 1; done
+for i in $(seq 30); do
+    curl http://localhost:8080/metrics > /dev/null 2>&1 && break
+    if [ $i -lt 30 ]; then
+        sleep 1
+    else
+        exit 1

Review Comment:
   Better to print the timeout message here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org