You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/28 05:27:46 UTC
[GitHub] [hbase] bharathv opened a new pull request #1099: HBASE-23604:
Clarify AsyncRegistry usage in the code. (#957)
bharathv opened a new pull request #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)
URL: https://github.com/apache/hbase/pull/1099
* HBASE-23604: Cleanup AsyncRegistry interface
- Cleans up the method names to make more sense and adds a little
more javadocs for context. In future patches we can revisit
the name of the actual class to make it more self explanatory.
- Does AsyncRegistry -> ConnectionRegistry rename.
"async" ness of the registry is kind of implicit based on
the interface contents and need not be reflected in the name.
Signed-off-by: Nick Dimiduk <nd...@apache.org>
Signed-off-by: stack <st...@apache.org>
Signed-off-by: Viraj Jasani <vj...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv closed pull request #1099: HBASE-23604: Clarify
AsyncRegistry usage in the code. (#957)
Posted by GitBox <gi...@apache.org>.
bharathv closed pull request #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)
URL: https://github.com/apache/hbase/pull/1099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1099: HBASE-23604: Clarify
AsyncRegistry usage in the code. (#957)
Posted by GitBox <gi...@apache.org>.
bharathv commented on issue #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)
URL: https://github.com/apache/hbase/pull/1099#issuecomment-581086410
Will be included in #1101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1099: HBASE-23604: Clarify
AsyncRegistry usage in the code. (#957)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)
URL: https://github.com/apache/hbase/pull/1099#issuecomment-579159093
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 42 new or modified test files. |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 12s | branch-2 passed |
| +1 :green_heart: | compile | 2m 24s | branch-2 passed |
| +1 :green_heart: | checkstyle | 2m 20s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 33s | branch-2 passed |
| +0 :ok: | spotbugs | 0m 35s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 35s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 53s | the patch passed |
| +1 :green_heart: | compile | 2m 22s | the patch passed |
| +1 :green_heart: | cc | 2m 22s | the patch passed |
| +1 :green_heart: | javac | 2m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-protocol-shaded |
| +1 :green_heart: | checkstyle | 0m 42s | hbase-client: The patch generated 0 new + 269 unchanged - 2 fixed = 269 total (was 271) |
| +1 :green_heart: | checkstyle | 0m 14s | The patch passed checkstyle in hbase-zookeeper |
| +1 :green_heart: | checkstyle | 1m 12s | hbase-server: The patch generated 0 new + 135 unchanged - 13 fixed = 135 total (was 148) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 18s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 29s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 2m 19s | the patch passed |
| +1 :green_heart: | javadoc | 1m 32s | the patch passed |
| +1 :green_heart: | findbugs | 8m 15s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 42s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 14m 10s | hbase-client in the patch failed. |
| +1 :green_heart: | unit | 0m 49s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 156m 19s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 2m 14s | The patch does not generate ASF License warnings. |
| | | 247m 37s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestClientNoCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1099/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1099 |
| JIRA Issue | HBASE-23604 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 975cd9909ee4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1099/out/precommit/personality/provided.sh |
| git revision | branch-2 / 2d5dfebb85 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1099/1/artifact/out/patch-unit-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1099/1/testReport/ |
| Max. process+thread count | 5185 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1099/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services