You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/11 11:17:45 UTC
[PR] Fix flaky WALNode outdated file deletion test [iotdb]
Caideyipi opened a new pull request, #17921:
URL: https://github.com/apache/iotdb/pull/17921
This PR makes WALNodeTest#testDeleteOutdatedFiles deterministic by explicitly rolling the WAL after flushing the old memtable. The previous test relied on 20000 writes exceeding the WAL size threshold, which can fail when serialized entry size changes. Tests: mvn -pl iotdb-core/datanode spotless:apply; git diff --check; mvn -pl iotdb-core/datanode -am -Dtest=WALNodeTest#testDeleteOutdatedFiles -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test (blocked locally by datanode generated ModeAccumulator compile errors before test execution).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky WALNode outdated file deletion test [iotdb]
Posted by "jt2594838 (via GitHub) via reviews" <re...@iotdb.apache.org>.
jt2594838 merged PR #17921:
URL: https://github.com/apache/iotdb/pull/17921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix flaky WALNode outdated file deletion test [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on PR #17921:
URL: https://github.com/apache/iotdb/pull/17921#issuecomment-6415141363
Self-review passed. I reviewed the complete diff and the surrounding WAL sequencing, and found no actionable issues. No code fixes were needed.
Verification:
- `WALNodeTest#testDeleteOutdatedFiles` passed with 1 test, 0 failures, and 0 errors in a clean 28-module reactor build.
- The default forked Surefire run was blocked by the local Windows virtual-memory limit; the targeted test passed with in-process Surefire (`-DforkCount=0`).
- Existing PR CI checks are green, including Linux and Windows DataNode unit tests and compile checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org