[jira] [Updated] (MINIFICPP-1268) Turn on warnings in Windows builds, and fix them

["Ferenc Gerlits (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MINIFICPP-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ferenc Gerlits updated MINIFICPP-1268:
--------------------------------------
    Description: 
In our Windows builds, we currently use warning level /W1 (severe warnings only).  On higher warning levels like /W3, there are many warnings, eg. about narrowing conversions.

For some reason, if I change the warning level to /W4, I get a linker error.
 # Change the warning level to /W3, and fix the warnings.
 # Investigate the problem with /W4, and either fix it or raise a follow-up Jira.

  was:
In our Windows builds, we currently use warning level /W1 (severe warnings only).  On higher warning levels, there are many warnings, eg. about narrowing conversions.

For some reason, if I change the warning level to the highest, /W4, I get a linker error.
 # Change the warning level to /W3, and fix the warnings.
 # Investigate the problem with /W4, and either fix it or raise a follow-up Jira.


> Turn on warnings in Windows builds, and fix them
> ------------------------------------------------
>
>                 Key: MINIFICPP-1268
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1268
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Ferenc Gerlits
>            Priority: Minor
>
> In our Windows builds, we currently use warning level /W1 (severe warnings only).  On higher warning levels like /W3, there are many warnings, eg. about narrowing conversions.
> For some reason, if I change the warning level to /W4, I get a linker error.
>  # Change the warning level to /W3, and fix the warnings.
>  # Investigate the problem with /W4, and either fix it or raise a follow-up Jira.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)