You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2009/03/19 19:32:50 UTC
[jira] Created: (PIG-726) Stop printing scope as part of
Operator.toString()
Stop printing scope as part of Operator.toString()
--------------------------------------------------
Key: PIG-726
URL: https://issues.apache.org/jira/browse/PIG-726
Project: Pig
Issue Type: Improvement
Reporter: Thejas M Nair
When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
For example, a line in explain is like -
ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
I am proposing that it should change to -
ForEach (id:4) Schema: {themap: map[ ]} Type: bag
That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-726) Stop printing scope as part of
Operator.toString()
Posted by "Gunther Hagleitner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689268#action_12689268 ]
Gunther Hagleitner commented on PIG-726:
----------------------------------------
I've made a simpler change that had similar effects in the multiquery branch. I basically set the scope to an integer (the scope is not really used right now as I understand it. It's a leftover from times when pig was designed as a standalone server). That way each operator will say: ForEach 1-4 (or 2-4 depending on how many instances of the pig server you have in your jvm.)
The alternative is to change all the logical operators name() function. They look something like: return <some info> + mKey.scope + "-" + mKey.id; For physical operators we could get away with the proposed change to key.toString() function.
That seems more painful.
> Stop printing scope as part of Operator.toString()
> --------------------------------------------------
>
> Key: PIG-726
> URL: https://issues.apache.org/jira/browse/PIG-726
> Project: Pig
> Issue Type: Improvement
> Reporter: Thejas M Nair
>
> When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
> For example, a line in explain is like -
> ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
> I am proposing that it should change to -
> ForEach (id:4) Schema: {themap: map[ ]} Type: bag
> That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-726) Stop printing scope as part of
Operator.toString()
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair reassigned PIG-726:
---------------------------------
Assignee: Gunther Hagleitner
> Stop printing scope as part of Operator.toString()
> --------------------------------------------------
>
> Key: PIG-726
> URL: https://issues.apache.org/jira/browse/PIG-726
> Project: Pig
> Issue Type: Improvement
> Reporter: Thejas M Nair
> Assignee: Gunther Hagleitner
>
> When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
> For example, a line in explain is like -
> ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
> I am proposing that it should change to -
> ForEach (id:4) Schema: {themap: map[ ]} Type: bag
> That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-726) Stop printing scope as part of
Operator.toString()
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-726.
--------------------------
> Stop printing scope as part of Operator.toString()
> --------------------------------------------------
>
> Key: PIG-726
> URL: https://issues.apache.org/jira/browse/PIG-726
> Project: Pig
> Issue Type: Improvement
> Reporter: Thejas M Nair
> Assignee: Gunther Hagleitner
> Fix For: 0.7.0
>
>
> When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
> For example, a line in explain is like -
> ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
> I am proposing that it should change to -
> ForEach (id:4) Schema: {themap: map[ ]} Type: bag
> That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-726) Stop printing scope as part of
Operator.toString()
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689513#action_12689513 ]
Thejas M Nair commented on PIG-726:
-----------------------------------
> I've made a simpler change that had similar effects in the multiquery branch.
> I basically set the scope to an integer
That will certainly help, I think we can use this fix. Or we can change the scope part to an empty string.
You are right that changing OperatorKey.toString() will not help in case of explain of Logical Plan, name() functions would have had to change.
> Stop printing scope as part of Operator.toString()
> --------------------------------------------------
>
> Key: PIG-726
> URL: https://issues.apache.org/jira/browse/PIG-726
> Project: Pig
> Issue Type: Improvement
> Reporter: Thejas M Nair
>
> When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
> For example, a line in explain is like -
> ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
> I am proposing that it should change to -
> ForEach (id:4) Schema: {themap: map[ ]} Type: bag
> That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-726) Stop printing scope as part of
Operator.toString()
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair resolved PIG-726.
-------------------------------
Resolution: Fixed
Scope is no longer verbose like before, after Gunther's changes as mentioned above. No further changes are required.
> Stop printing scope as part of Operator.toString()
> --------------------------------------------------
>
> Key: PIG-726
> URL: https://issues.apache.org/jira/browse/PIG-726
> Project: Pig
> Issue Type: Improvement
> Reporter: Thejas M Nair
> Assignee: Gunther Hagleitner
>
> When an operator is printed in pig, it prints a string with the user name and date at which the grunt shell was started. This information is not useful and makes the output very verbose.
> For example, a line in explain is like -
> ForEach tejas-Thu Mar 19 11:25:23 PDT 2009-4 Schema: {themap: map[ ]} Type: bag
> I am proposing that it should change to -
> ForEach (id:4) Schema: {themap: map[ ]} Type: bag
> That string comes from scope in OperatorKey class. We don't use make use of it anywhere, so we should stop printing it. The change is only in OperatorKey.toString();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.