You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gaborhermann <gi...@git.apache.org> on 2015/03/10 16:21:44 UTC

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

GitHub user gaborhermann opened a pull request:

    https://github.com/apache/flink/pull/472

    [FLINK-1594] [streaming] [wip] DataStream supports self-connection

    * Added StreamEdge abstraction, so more than one edge can be defined between stream operators.
    * Added OutputSelectorWrapper to avoid directed emission spreading over all the code.
    * Added factories for reader and writer creation
    
    Travis fails on StreamVertexTest.coTest() (it gets stuck). Locally it passes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbalassi/flink flink-1594

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #472
    
----
commit 05ddfcae90a22dbb1b18faff262bfe0398b07650
Author: Gábor Hermann <re...@gmail.com>
Date:   2015-02-26T12:16:32Z

    [FLINK-1594] [streaming] Added StreamGraphEdges

commit 29db310d5d84417c90b657e8dd6e87a0ec89fa37
Author: Gábor Hermann <re...@gmail.com>
Date:   2015-02-26T15:15:17Z

    [FLINK-1594] [streaming] Embedded StreamEdges

commit bf881773ef8d02ef9750bbfaec41423355878230
Author: Gábor Hermann <re...@gmail.com>
Date:   2015-02-27T10:40:01Z

    [FLINK-1594] [streaming] Fixed co-tasks input handling

commit 1719a4e608e301e8a28599299c5eb27748da8c50
Author: Gábor Hermann <re...@gmail.com>
Date:   2015-03-02T09:20:14Z

    [FLINK-1594] [streaming] Added OutputSelector wrapping

commit 722a01ea2a42510f08df407278d1b6d0247b0670
Author: Gábor Hermann <re...@gmail.com>
Date:   2015-03-05T14:51:51Z

    [streaming] Added Reader and Writer factories & minor cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/472#issuecomment-78172073
  
    Looks good to me, and travis passes, I will merge tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/472#issuecomment-78211739
  
    What about the stuck test? Did you look into it or did just a re run of Travis pass?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/472#issuecomment-78212746
  
    It was missing about 10 commits from the master, and after rebasing the tests ran properly. But I didnt investigate the issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/472#issuecomment-78431621
  
    Ok seems like there is an issue with chained tasks, so lets not merge it until that is fixed. Gabor is working on it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1594] [streaming] [wip] DataStream supp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/472


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---