[GitHub] [airflow] JulesTriomphe commented on a diff in pull request #27419: Add webserverConfigConfigmapName

[GitBox <gi...@apache.org>]

JulesTriomphe commented on code in PR #27419:
URL: https://github.com/apache/airflow/pull/27419#discussion_r1038385167


##########
tests/charts/test_webserver.py:
##########
@@ -738,6 +750,45 @@ def test_webserver_config_configmap(self):
             == jmespath.search('data."webserver_config.py"', docs[0]).strip()
         )
 
+    def test_webserver_config_configmap_name_volume_mounts(self):
+        configmap_name = "my-configmap"
+        docs = render_chart(
+            values={
+                "scheduler": {"logGroomerSidecar": {"enabled": True}, "waitForMigrations": {"enabled": True}},
+                "triggerer": {"waitForMigrations": {"enabled": True}},

Review Comment:
   Without these we don't test whether the configMap has been mounted to these initContainers and sidecars. I think we should leave these defaults.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org