You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 22:06:28 UTC

Re: Review Request 53716: Used `Shell::entrypoint`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53716/#review159755
-----------------------------------------------------------


Fix it, then Ship it!




I can tweak this before committing.


src/docker/docker.cpp (line 790)
<https://reviews.apache.org/r/53716/#comment230802>

    See: https://reviews.apache.org/r/53715/#comment230690
    
    For some reason, this file/class is not namespaced, so defining constants will be awkward.  However, as there are only these two lines to change, we can just `#ifdef` in place.



src/docker/docker.cpp (line 805)
<https://reviews.apache.org/r/53716/#comment230804>

    Ditto here.


- Joseph Wu


On Nov. 13, 2016, 9:43 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53716/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `Shell::entrypoint`.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e 
> 
> Diff: https://reviews.apache.org/r/53716/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>