You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by dk...@apache.org on 2019/12/18 01:01:23 UTC

[sling-org-apache-sling-app-cms] branch SLING-8919-fix-error-dialog updated: SLING-8919 - Cleaning up a couple eslint warnings

This is an automated email from the ASF dual-hosted git repository.

dklco pushed a commit to branch SLING-8919-fix-error-dialog
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-app-cms.git


The following commit(s) were added to refs/heads/SLING-8919-fix-error-dialog by this push:
     new 4369988  SLING-8919 - Cleaning up a couple eslint warnings
4369988 is described below

commit 43699881253c9490ad223713fbb8e9ca3dd445da
Author: Dan Klco <dk...@apache.org>
AuthorDate: Tue Dec 17 17:01:07 2019 -0800

    SLING-8919 - Cleaning up a couple eslint warnings
---
 ui/src/main/frontend/js/cms.fields.js | 2 +-
 ui/src/main/frontend/js/editor.js     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ui/src/main/frontend/js/cms.fields.js b/ui/src/main/frontend/js/cms.fields.js
index 3ee6765..a76e429 100644
--- a/ui/src/main/frontend/js/cms.fields.js
+++ b/ui/src/main/frontend/js/cms.fields.js
@@ -62,7 +62,7 @@ rava.bind('.file', {
               meter.classList.add('is-success');
             } else {
               meter.classList.add('is-danger');
-              console.warn('Failed to upload %s, recieved message %s', file.name, text);
+              console.warn('Failed to upload %s, recieved message %s', file.name, text); // eslint-disable-line no-console
             }
           }
         }, false);
diff --git a/ui/src/main/frontend/js/editor.js b/ui/src/main/frontend/js/editor.js
index 62ab929..e6c204a 100644
--- a/ui/src/main/frontend/js/editor.js
+++ b/ui/src/main/frontend/js/editor.js
@@ -257,7 +257,7 @@ if (!window.CMSEditor) {
         ed.addEventListener('dragend', deactivateTargets);
       },
       attachEvents(ctx) {
-        CMSEditor.util.attachClick(ctx, '.sling-cms-editor .action-button', function (event) {
+        CMSEditor.util.attachClick(ctx, '.sling-cms-editor .action-button', (event) => {
           event.preventDefault();
           CMSEditor.ui.showModal(this.href, this.title);
         });
@@ -293,7 +293,7 @@ if (!window.CMSEditor) {
     },
   };
   window.CMSEditor = CMSEditor;
-  window.onbeforeunload = function () {
+  window.onbeforeunload = () => {
     if (CMSEditor.ui.modalDisplayed) {
       return 'Are you sure you want to leave this page?';
     }