You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/06 21:48:39 UTC
[GitHub] [beam] pabloem commented on a change in pull request #12175: [BEAM-10201] Reduce scope of ParseResult AutoValue properties.
pabloem commented on a change in pull request #12175:
URL: https://github.com/apache/beam/pull/12175#discussion_r450497368
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java
##########
@@ -334,27 +335,27 @@ private ObjectMapper objectMapper() {
@AutoValue
public abstract static class ParseResult implements POutput {
- public abstract JsonToRowWithErrFn getJsonToRowWithErrFn();
+ abstract JsonToRowWithErrFn getJsonToRowWithErrFn();
- public abstract PCollection<Row> getParsedLine();
+ abstract PCollection<Row> getParsedLine();
- public abstract PCollection<Row> getFailedParse();
+ abstract PCollection<Row> getFailedParse();
Review comment:
Aren't these two the methods that users will be trying to access?
(others LGTM)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org