[jira] [Commented] (DOXIASITETOOLS-118) Separate inheritance and interpolation

["Hervé Boutemy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIASITETOOLS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091136#comment-15091136 ] 

Hervé Boutemy commented on DOXIASITETOOLS-118:
----------------------------------------------

I'm having a look at this issue: yes, interpolation should happen after inheritance, or we'll have strange results

if the only found issue is MSITE-312, I really don't understand how MSITE-312 can be a valid issue: parent site refers to a property that does not exist when rendering parent
the IT just tests the current behaviour, which I would call inconsistent
to me, we should merge RObert's patch and update MSITE-312 IT
or even remove it, since I'll add in a few minutes a "inheritance-interpolation" IT taht shows the issue with current behaviour, where interpolation happens in the context that the expression is defined

> Separate inheritance and interpolation 
> ---------------------------------------
>
>                 Key: DOXIASITETOOLS-118
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-118
>             Project: Maven Doxia Sitetools
>          Issue Type: Improvement
>          Components: Integration Tools
>    Affects Versions: doxia-integration-tools-1.4
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>             Fix For: 1.7
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like {{${project.name\}}}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)