You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "justinwwhuang (via GitHub)" <gi...@apache.org> on 2024/05/12 07:04:39 UTC
[PR] [INLONG-10091][Agent] Delete useless code [inlong]
justinwwhuang opened a new pull request, #10192:
URL: https://github.com/apache/inlong/pull/10192
Fixes #10091
### Motivation
The agent does not listen to the port, and the relevant code is useless
### Modifications
Delete useless code
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
No doc needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [inlong]
Posted by "justinwwhuang (via GitHub)" <gi...@apache.org>.
justinwwhuang commented on PR #10192:
URL: https://github.com/apache/inlong/pull/10192#issuecomment-2106488841
> please remove https://github.com/apache/inlong/blob/master/docker/docker-compose/docker-compose.yml#L102-L103 and https://github.com/apache/inlong/blob/master/inlong-agent/agent-docker/Dockerfile#L30
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #10192:
URL: https://github.com/apache/inlong/pull/10192#issuecomment-2106567792
> Please update https://inlong.apache.org/docs/next/modules/agent/configure
updated in https://github.com/apache/inlong-website/pull/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #10192:
URL: https://github.com/apache/inlong/pull/10192#issuecomment-2106540773
Please update https://inlong.apache.org/docs/next/modules/agent/configure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [inlong]
Posted by "justinwwhuang (via GitHub)" <gi...@apache.org>.
justinwwhuang merged PR #10192:
URL: https://github.com/apache/inlong/pull/10192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete useless code [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #10192:
URL: https://github.com/apache/inlong/pull/10192#issuecomment-2106226797
please remove https://github.com/apache/inlong/blob/master/docker/docker-compose/docker-compose.yml#L102-L103 and https://github.com/apache/inlong/blob/master/inlong-agent/agent-docker/Dockerfile#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #10192:
URL: https://github.com/apache/inlong/pull/10192#issuecomment-2106540575
public static final String AGENT_ENABLE_HTTP = "agent.http.enable";
public static final boolean DEFAULT_AGENT_ENABLE_HTTP = false; these codes should also be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org