You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2017/07/26 15:42:11 UTC
Review Request 61140: Ambari REST API to support setting rack info
during add host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
Bugs: AMBARI-21575
https://issues.apache.org/jira/browse/AMBARI-21575
Repository: ambari
Description
-------
The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
Diff: https://reviews.apache.org/r/61140/diff/1/
Testing
-------
Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
Unit tests:
Results :
Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
[INFO] skipping execute as per configuraion
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
[INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
[INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
[INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
[INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
[INFO] Ambari Server ...................................... SUCCESS [51:41 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:54 min
[INFO] Finished at: 2017-07-26T16:38:04+02:00
[INFO] Final Memory: 61M/511M
[INFO] ------------------------------------------------------------------------
Thanks,
Sebastian Toader
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181553
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On July 26, 2017, 5:42 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 5:42 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/1/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181561
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
Lines 508-510 (patched)
<https://reviews.apache.org/r/61140/#comment257149>
This is not a proper JavaDoc
```
/**
...
*/
```
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
Lines 533-536 (patched)
<https://reviews.apache.org/r/61140/#comment257151>
Not a proper JavaDoc comment
- Robert Levas
On July 26, 2017, 11:42 a.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 11:42 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/1/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181550
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On July 26, 2017, 3:42 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 3:42 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/1/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181564
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On July 26, 2017, 3:42 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 3:42 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/1/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181573
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On July 27, 2017, 11:25 a.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/2/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/
-----------------------------------------------------------
(Updated July 27, 2017, 5:25 p.m.)
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
Changes
-------
Addressed review comments.
Bugs: AMBARI-21575
https://issues.apache.org/jira/browse/AMBARI-21575
Repository: ambari
Description
-------
The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
Diff: https://reviews.apache.org/r/61140/diff/2/
Changes: https://reviews.apache.org/r/61140/diff/1-2/
Testing
-------
Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
Unit tests:
Results :
Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
[INFO] skipping execute as per configuraion
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
[INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
[INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
[INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
[INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
[INFO] Ambari Server ...................................... SUCCESS [51:41 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:54 min
[INFO] Finished at: 2017-07-26T16:38:04+02:00
[INFO] Final Memory: 61M/511M
[INFO] ------------------------------------------------------------------------
Thanks,
Sebastian Toader
Re: Review Request 61140: Ambari REST API to support setting rack info
during add host
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181555
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On July 26, 2017, 3:42 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61140/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 3:42 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, and Sandor Magyari.
>
>
> Bugs: AMBARI-21575
> https://issues.apache.org/jira/browse/AMBARI-21575
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API should accept rack info for the hosts being added to the cluster similar to how updating hosts via ```PUT http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` is done.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 8ef42ba
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java fe56760
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java a4cc6fc
>
>
> Diff: https://reviews.apache.org/r/61140/diff/1/
>
>
> Testing
> -------
>
> Manual testing the ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts``` and ```POST http://<ambari-server>:<port>/api/v1/clusters/<cluster_name>/hosts/<host_name>``` REST API.
>
> Unit tests:
> Results :
>
> Tests run: 4815, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 0.558 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.003 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.423 s]
> [INFO] ambari-utility ..................................... SUCCESS [ 3.240 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.185 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.716 s]
> [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.382 s]
> [INFO] Ambari Server ...................................... SUCCESS [51:41 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:54 min
> [INFO] Finished at: 2017-07-26T16:38:04+02:00
> [INFO] Final Memory: 61M/511M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sebastian Toader
>
>