You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by reveller <gi...@git.apache.org> on 2016/09/27 13:53:29 UTC
[GitHub] trafficserver pull request #1051: TS-4558: ASAN buffer overflow in traffic_m...
GitHub user reveller opened a pull request:
https://github.com/apache/trafficserver/pull/1051
TS-4558: ASAN buffer overflow in traffic_manager -h
Changed (int *) to a (bool *) for boolean based arguments in usage().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reveller/trafficserver TS-4558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1051
----
commit db70e4d80fdd9b4dc073741761a9cc425a4465b8
Author: Steven Feltner <sf...@godaddy.com>
Date: 2016-09-27T13:46:48Z
TS-4558: ASAN buffer overflow in traffic_manager -h
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1051: TS-4558: ASAN buffer overflow in traffic_m...
Posted by reveller <gi...@git.apache.org>.
Github user reveller closed the pull request at:
https://github.com/apache/trafficserver/pull/1051
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1051: TS-4558: ASAN buffer overflow in traffic_m...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1051#discussion_r80715731
--- Diff: lib/ts/ink_args.cc ---
@@ -320,7 +320,7 @@ usage(const ArgumentDescription *argument_descriptions, unsigned n_argument_desc
case 'f':
case 'F':
if (argument_descriptions[i].location) {
- fprintf(stderr, " %-9s", *(int *)argument_descriptions[i].location ? "true " : "false");
+ fprintf(stderr, " %-9s", *(bool *)argument_descriptions[i].location ? "true " : "false");
--- End diff --
Every other place that has a flag argument uses an ``int`` for the flag. This should be consistent, so if you change the flag type, you need to change it everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---