You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/19 04:00:35 UTC
Review Request 63135: Refactor Job Page to make it more pluggable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/
-----------------------------------------------------------
Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
Diffs
-----
ui/src/main/js/components/JobHistory.js PRE-CREATION
ui/src/main/js/components/JobOverview.js PRE-CREATION
ui/src/main/js/components/JobStatus.js PRE-CREATION
ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
Diff: https://reviews.apache.org/r/63135/diff/1/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
Thanks,
David McLaughlin
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188742
-----------------------------------------------------------
Ship it!
LGTM
ui/src/main/js/components/Tabs.js
Lines 7 (patched)
<https://reviews.apache.org/r/63135/#comment265765>
s/his/this/
- Kai Huang
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188756
-----------------------------------------------------------
@ReviewBot retry
- David McLaughlin
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188636
-----------------------------------------------------------
Master (0622f34) is red with this patch.
./build-support/jenkins/build.sh
org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:203
I1019 04:09:16.812 [ShutdownHook, SchedulerMain] Stopping scheduler services.
852 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.77, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 6' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.77, but expected minimum is 0.87
Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 8m 3s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Oct. 19, 2017, 8:24 p.m., Kai Huang wrote:
> > Fix the gradle build error:
> > ```
> > * Exception is:
> > org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':ui:test'.
> > at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:100)
> > ```
I cannot recreate this locally. Are you sure this isn't another problem with your local environment?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188749
-----------------------------------------------------------
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188749
-----------------------------------------------------------
Fix the gradle build error:
```
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':ui:test'.
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:100)
```
- Kai Huang
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188741
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Oct. 18, 2017, 9 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 9 p.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188638
-----------------------------------------------------------
Master (0622f34) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:testI1019 04:28:34.417 [ShutdownHook, SchedulerMain] Stopping scheduler services.
org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:203
1137 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 7m 11s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188761
-----------------------------------------------------------
Ship it!
Master (b9ede2f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 19, 2017, 9:06 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 9:06 p.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/2/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 9:06 p.m.)
Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
Diffs (updated)
-----
ui/src/main/js/components/JobHistory.js PRE-CREATION
ui/src/main/js/components/JobOverview.js PRE-CREATION
ui/src/main/js/components/JobStatus.js PRE-CREATION
ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
Diff: https://reviews.apache.org/r/63135/diff/2/
Changes: https://reviews.apache.org/r/63135/diff/1-2/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
Thanks,
David McLaughlin
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188637
-----------------------------------------------------------
@ReviewBot retry
- David McLaughlin
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63135: Refactor Job Page to make it more pluggable
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63135/#review188758
-----------------------------------------------------------
Master (b9ede2f) is red with this patch.
./build-support/jenkins/build.sh
✖ 1 problem (1 error, 0 warnings)
npm ERR! Linux 4.4.0-89-generic
npm ERR! argv "/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/node" "/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/npm" "run" "lint"
npm ERR! node v6.9.1
npm ERR! npm v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! apache-aurora@1.0.0 lint: `eslint src/main/js --ext .js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the apache-aurora@1.0.0 lint script 'eslint src/main/js --ext .js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the apache-aurora package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! eslint src/main/js --ext .js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs apache-aurora
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls apache-aurora
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/jenkins/jenkins-slave/workspace/AuroraBot/ui/npm-debug.log
:ui:lint FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':ui:lint'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/npm'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 5m 23s
58 actionable tasks: 47 executed, 11 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 19, 2017, 4 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63135/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme).
>
> Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing).
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js PRE-CREATION
> ui/src/main/js/components/JobOverview.js PRE-CREATION
> ui/src/main/js/components/JobStatus.js PRE-CREATION
> ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8
> ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81
> ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9
> ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af
> ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202
>
>
> Diff: https://reviews.apache.org/r/63135/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> Thanks,
>
> David McLaughlin
>
>