[GitHub] [flink] bowenli86 opened a new pull request #10575: Hive2

[GitBox <gi...@apache.org>]

bowenli86 opened a new pull request #10575: Hive2
URL: https://github.com/apache/flink/pull/10575
 
 
   ## What is the purpose of the change
   
   discovered a couple bugs in HiveCatalog, related code seem to have been manipulated and introduced bugs but we didn't find it due to lack of test coverage. Fix them now and add more UT and IT.
   
   [FLINK-15234] hive table created from flink catalog table cannot have null properties in parameters - this one is when user created table doesn't have comment (null), we still put it into a hive table's params and HMS reports error. Solution: don't put 'comment' into hive table param if its value is null
   
   [FLINK-15240] is_generic key is missing for Flink table stored in HiveCatalog - the is_generic key is missing for generic tables stored in HiveCatalog. the expected behavior is: 
   
   - When creating a table, A hive table needs explicitly have a key is_generic = false; otherwise, this is a generic table if 1) the key is missing 2) is_generic = true
   - When retrieving a table, a generic table needs explicitly have a key is_generic = true; otherwise, this is a Hive table if 1) the key is missing 2) is_generic = false
   
   ## Brief change log
   
   fix bugs mentioned above, added more UT and IT
   
   ## Verifying this change
   
   This change added tests and can be verified as `HiveCatalogTest` and `HiveCatalogITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
   n/a
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs / JavaDocs)
   
   docs will be updated later
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services