You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2019/03/27 18:57:08 UTC

[incubator-superset] branch john-bodley--fix-migration-fb13d49b72f9 created (now 0c021bd)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley--fix-migration-fb13d49b72f9
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at 0c021bd  [migration] Fixing issue with fb13d49b72f9 downgrade

This branch includes the following new commits:

     new 0c021bd  [migration] Fixing issue with fb13d49b72f9 downgrade

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-superset] 01/01: [migration] Fixing issue with fb13d49b72f9 downgrade

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--fix-migration-fb13d49b72f9
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 0c021bdd031303f9721972e54f48478aa50112ae
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Wed Mar 27 11:56:52 2019 -0700

    [migration] Fixing issue with fb13d49b72f9 downgrade
    
    This PR fixes an issue with the downgrade step of migration fb13d49b72f9 which wrongfully labeled the field `metrics` rather than `metric`.
    
    to: @graceguo-supercat @michellethomas @mistercrunch
---
 superset/migrations/versions/fb13d49b72f9_better_filters.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/migrations/versions/fb13d49b72f9_better_filters.py b/superset/migrations/versions/fb13d49b72f9_better_filters.py
index cac42c3..123a708 100644
--- a/superset/migrations/versions/fb13d49b72f9_better_filters.py
+++ b/superset/migrations/versions/fb13d49b72f9_better_filters.py
@@ -94,7 +94,7 @@ def downgrade():
             flts = params.get('filter_configs')
             if not flts:
                 continue
-            params['metrics'] = [flts[0].get('metric')]
+            params['metric'] = [flts[0].get('metric')]
             params['groupby'] = [o.get('column') for o in flts]
             slc.params = json.dumps(params, sort_keys=True)
         except Exception as e: