You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2026/04/24 20:39:11 UTC
[PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
snuyanzin opened a new pull request, #28029:
URL: https://github.com/apache/flink/pull/28029
## What is the purpose of the change
If tests are running in parallel they might reuse the same sink by name and sink will contain unexpected results
The idea is to use more unique sinks
examples of failure
https://github.com/apache/flink/actions/runs/24881538481/job/72892870040#step:12:10351
https://github.com/apache/flink/actions/runs/24895816554/job/72901841273#step:12:10351
https://github.com/apache/flink/actions/runs/24892915051/job/72897348906#step:12:10353
https://github.com/apache/flink/actions/runs/24904840364/job/72933022675#step:12:10352
## Brief change log
it is test
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
- The S3 file system connector: (no )
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable )
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #28029:
URL: https://github.com/apache/flink/pull/28029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28029:
URL: https://github.com/apache/flink/pull/28029#issuecomment-4318566747
here it is a link to GHA run on my fork https://github.com/snuyanzin/flink/actions/runs/24924498645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28029:
URL: https://github.com/apache/flink/pull/28029#issuecomment-4316283998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9d42289f4c6b1472cf7965d42fe48c0cc655b3c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9d42289f4c6b1472cf7965d42fe48c0cc655b3c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9d42289f4c6b1472cf7965d42fe48c0cc655b3c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #28029:
URL: https://github.com/apache/flink/pull/28029#discussion_r3143198994
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/common/sql/SinkReuseITCase.java:
##########
@@ -191,4 +199,8 @@ private void assertResult(List<String> expected, List<String> actual) {
Collections.sort(actual);
assertThat(actual).isEqualTo(expected);
}
+
+ private String getTableNameWithPrefix(final String name) {
Review Comment:
nit: not aware of context, but shows never called anywhere in this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #28029:
URL: https://github.com/apache/flink/pull/28029#discussion_r3143198994
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/common/sql/SinkReuseITCase.java:
##########
@@ -191,4 +199,8 @@ private void assertResult(List<String> expected, List<String> actual) {
Collections.sort(actual);
assertThat(actual).isEqualTo(expected);
}
+
+ private String getTableNameWithPrefix(final String name) {
Review Comment:
nit: shows never called anywhere in this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #28029:
URL: https://github.com/apache/flink/pull/28029#discussion_r3143212129
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/common/sql/SinkReuseITCase.java:
##########
@@ -191,4 +199,8 @@ private void assertResult(List<String> expected, List<String> actual) {
Collections.sort(actual);
assertThat(actual).isEqualTo(expected);
}
+
+ private String getTableNameWithPrefix(final String name) {
Review Comment:
true, thanks
artifact from prev approach
dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][test] Use unique sink name in `CascadedDeltaJoinITCase` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28029:
URL: https://github.com/apache/flink/pull/28029#issuecomment-4316223032
@xuyangzhong since you are one of the main contributors here would great if you can take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org