You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2024/01/10 17:46:39 UTC
[PR] Use `mariadb` by default when build final prod image [airflow]
Taragolis opened a new pull request, #36716:
URL: https://github.com/apache/airflow/pull/36716
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
We forget to change default value for `INSTALL_MYSQL_CLIENT_TYPE` argument to `mariadb`.
So we build packages by MariaDB libraries, however finally install mysql.
This only affects `X86_64` images because for ARM we always use MariaDB libraries regardless of this build argument
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #36716:
URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885360700
Yeah I think also need to mention that if someone build custom image from 2.8.0 branch then should specify `INSTALL_MYSQL_CLIENT_TYPE=mariadb`
Let me find better place for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #36716:
URL: https://github.com/apache/airflow/pull/36716#discussion_r1447796040
##########
docker_tests/test_prod_image.py:
##########
@@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self):
"grpc": ["grpc", "google.auth", "google_auth_httplib2"],
"hashicorp": ["hvac"],
"ldap": ["ldap"],
+ "mysql": ["MySQLdb", *(["mysql"] if bool(find_spec("mysql")) else [])],
Review Comment:
We should always check `import MySQLdb` which should prevent regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36716:
URL: https://github.com/apache/airflow/pull/36716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36716:
URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885351034
I guess we should also mention that in the docker-stack release notes (changing 2.8.0 -> 2.8.1) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36716:
URL: https://github.com/apache/airflow/pull/36716#discussion_r1447809733
##########
docker_tests/test_prod_image.py:
##########
@@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self):
"grpc": ["grpc", "google.auth", "google_auth_httplib2"],
"hashicorp": ["hvac"],
"ldap": ["ldap"],
+ "mysql": ["MySQLdb", *(["mysql"] if bool(find_spec("mysql")) else [])],
Review Comment:
Hmm.. Should we rebuild 2.8.0 images I guesss (I see that the released images are failing - but we can rebuild and repush the images with Mariadb, that should be easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36716:
URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885584102
Merged. Re-building images here https://github.com/apache/airflow/actions/runs/7479928533/job/20358188520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36716:
URL: https://github.com/apache/airflow/pull/36716#discussion_r1447860225
##########
docker_tests/test_prod_image.py:
##########
@@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self):
"grpc": ["grpc", "google.auth", "google_auth_httplib2"],
"hashicorp": ["hvac"],
"ldap": ["ldap"],
+ "mysql": ["MySQLdb", *(["mysql"] if bool(find_spec("mysql")) else [])],
Review Comment:
Right - we can easily rebuild the images using `main` Dockerfile, so let me merge it and rebuild the images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #36716:
URL: https://github.com/apache/airflow/pull/36716#discussion_r1447825517
##########
docker_tests/test_prod_image.py:
##########
@@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self):
"grpc": ["grpc", "google.auth", "google_auth_httplib2"],
"hashicorp": ["hvac"],
"ldap": ["ldap"],
+ "mysql": ["MySQLdb", *(["mysql"] if bool(find_spec("mysql")) else [])],
Review Comment:
Yeah I think it would be the best option, rather than think provide workaround how to properly remove MySQL libraries and replace them by MariaDB.
Otherwise we would have multiple issues everywhere: Github / Slack / SO.
Seems like all holidays is over and users started to upgrade their Airflow instances 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `mariadb` by default when build final prod image [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36716:
URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885621547
OK. Images refreshed - they failed verification, but the verification failure was "fab" provider missing (which is expected).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org