You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/14 03:06:05 UTC
[GitHub] [skywalking] tuohai666 opened a new issue #4229: Provide plugin for
ShardingSphere 4.0.0
tuohai666 opened a new issue #4229: Provide plugin for ShardingSphere 4.0.0
URL: https://github.com/apache/skywalking/issues/4229
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [x] Requirement
- [ ] Feature or performance improvement
Provide plugin for ShardingSphere 4.0.0 of which the package name is different from RC3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4229: Provide plugin for
ShardingSphere 4.0.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4229: Provide plugin for ShardingSphere 4.0.0
URL: https://github.com/apache/skywalking/issues/4229#issuecomment-582942727
@tuohai666 Any progress?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4229: Provide
plugin for ShardingSphere 4.0.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4229: Provide plugin for ShardingSphere 4.0.0
URL: https://github.com/apache/skywalking/issues/4229#issuecomment-573995054
@tuohai666 I hope you could refactor the existed codes of ShardingSphere plugins in this issue too, there're many duplicated codes, we could have much more clean codes :smile:
maybe a `shardingsphere-commons` module or whatever I don't know, maybe take the `Spring` plugins as an example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tuohai666 commented on issue #4229: Provide plugin for
ShardingSphere 4.0.0
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #4229: Provide plugin for ShardingSphere 4.0.0
URL: https://github.com/apache/skywalking/issues/4229#issuecomment-574025370
@kezhenxu94 You are right. ShardingSphere changed api or package name in every release, more plugins will be provided subsequently. It's time to extract common codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4229: Provide plugin
for ShardingSphere 4.0.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4229: Provide plugin for ShardingSphere 4.0.0
URL: https://github.com/apache/skywalking/issues/4229#issuecomment-573995054
@tuohai666 I hope you could refactor the existed codes of ShardingSphere plugins in this issue too, there're many duplicated codes, we could have much more clean codes :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services