You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2019/05/31 10:13:39 UTC

[GitHub] [brooklyn-client] jcabrerizo commented on a change in pull request #77: Allow sent user defined headers and omit credentials if not needed

jcabrerizo commented on a change in pull request #77: Allow sent user defined headers and omit credentials if not needed
URL: https://github.com/apache/brooklyn-client/pull/77#discussion_r289333479
 
 

 ##########
 File path: cli/io/config.go
 ##########
 @@ -114,32 +111,20 @@ func (config *Config) read() {
 //    "target": "http://geoffs-macbook-pro.local:8081"
 //}
 
-func (config *Config) getCredentials(target string) (username string, password string, err error) {
-	credentials, found := config.Map[credentialsKey].(map[string]interface{})
+func (config *Config) getCredentials(target string) (credentials string, err error) {
+	credentialsMap, found := config.Map[credentialsKey].(map[string]interface{})
 
 Review comment:
   OK, lets do it, but not in this PR nor today :D. 
   I'd like continue learning go, please explain me how you'd improve this and i'll try to do if in future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services